Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Prevent inclusion of phpunit/phpunit in PHAR #342

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix: Prevent inclusion of phpunit/phpunit in PHAR #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
dependencies: "${{ matrix.dependencies }}"

- name: "Remove phpunit/phpunit"
run: "composer remove phpiunit/phpunit --ansi --no-interaction --no-progress"
run: "composer remove phpunit/phpunit --ansi --no-interaction --no-progress"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfredbez

🤦‍♂️

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the proof, that you're a human. Looking at your contributions I was actually questioning that already. Hope to also see you in person at some time

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alfredbez!

Perhaps at the next PHPUnit code sprint?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding that to my calender, will check if my company can support me with that 👍


- name: "Install dependencies with phive"
uses: "ergebnis/.github/actions/phive/[email protected]"
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

For a full diff see [`2.3.0...main`][2.3.0...main].

### Fixed

- Prevented inclusion of `phpunit/phpunit` in PHAR ([#342]), by [@localheinz]

## [`2.3.0`][2.3.0]

For a full diff see [`2.2.0...2.3.0`][2.2.0...2.3.0].
Expand Down Expand Up @@ -142,5 +146,6 @@ For a full diff see [`7afa59c...1.0.0`][7afa59c...1.0.0].
[#272]: https://github.com/ergebnis/phpunit-slow-test-detector/pull/272
[#273]: https://github.com/ergebnis/phpunit-slow-test-detector/pull/273
[#340]: https://github.com/ergebnis/phpunit-slow-test-detector/pull/340
[#342]: https://github.com/ergebnis/phpunit-slow-test-detector/pull/342

[@localheinz]: https://github.com/localheinz