Fix: Prevent inclusion of phpunit/phpunit in PHAR
#342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
fix/remove
branch
from
264bf0f to
0d57145
Compare
localheinz
commented
Oct 13, 2023
| run: "composer remove phpiunit/phpunit --ansi --no-interaction --no-progress" | ||
| run: "composer remove phpunit/phpunit --ansi --no-interaction --no-progress" |
There was a problem hiding this comment.
This is the proof, that you're a human. Looking at your contributions I was actually questioning that already. Hope to also see you in person at some time
There was a problem hiding this comment.
Thank you, @alfredbez!
Perhaps at the next PHPUnit code sprint?
There was a problem hiding this comment.
Adding that to my calender, will check if my company can support me with that 👍
Codecov Report
@@ Coverage Diff @@
## main #342 +/- ##
=========================================
Coverage 94.64% 94.64%
Complexity 61 61
=========================================
Files 15 15
Lines 299 299
=========================================
Hits 283 283
Misses 16 16 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
phpunit/phpunitin the compiled PHARFixes #334.