Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove abstract test case #888

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix: Remove abstract test case #888

merged 1 commit into from
Jan 6, 2025

Conversation

localheinz
Copy link
Member

This pull request

  • removes the abstract test case

@localheinz localheinz self-assigned this Jan 5, 2025
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.48%. Comparing base (317259a) to head (b9e3cf9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #888   +/-   ##
=========================================
  Coverage     97.48%   97.48%           
  Complexity      204      204           
=========================================
  Files            23       23           
  Lines           717      717           
=========================================
  Hits            699      699           
  Misses           18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@localheinz localheinz force-pushed the fix/abstract branch 12 times, most recently from 56ce025 to d4c1e3c Compare January 6, 2025 09:06
[
\sprintf(
'Method %s::method() is protected, but since the containing class is final, it can be private.',
Test\Fixture\Methods\PrivateInFinalClassRule\FinalClassWithProtectedMethodFromTrait::class,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #838.

@localheinz localheinz force-pushed the fix/abstract branch 5 times, most recently from 02cb235 to c7c2bc3 Compare January 6, 2025 10:40
@localheinz localheinz marked this pull request as ready for review January 6, 2025 10:40
@localheinz localheinz merged commit dfa9a07 into main Jan 6, 2025
25 checks passed
@localheinz localheinz deleted the fix/abstract branch January 6, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants