Fix: Remove abstract test case

ergebnis · Jan 6, 2025 · d4c1e3c · d4c1e3c
1 parent 317259a
commit d4c1e3c
Show file tree

Hide file tree

Showing 190 changed files with 782 additions and 1,844 deletions.
diff --git a/.php-cs-fixer.fixture.php b/.php-cs-fixer.fixture.php
@@ -26,6 +26,7 @@
         'lowercase_keywords' => false,
         'magic_method_casing' => false,
         'native_function_casing' => false,
+        'native_function_invocation' => false,
         'nullable_type_declaration' => false,
         'protected_to_private' => false,
         'static_lambda' => false,
@@ -36,11 +37,10 @@
 $config->getFinder()
     ->in(__DIR__ . '/test/Fixture/')
     ->notPath([
-        'Classes/PHPUnit/Framework/TestCaseWithSuffixRule/Success/ImplicitlyAbstractTestCase.php',
-        'Closures/NoNullableReturnTypeDeclarationRule/Failure/closure-with-nullable-union-type-return-type-declaration.php',
-        'Closures/NoParameterWithNullableTypeDeclarationRule/Failure/closure-with-parameter-with-nullable-union-type-declaration.php',
-        'Functions/NoNullableReturnTypeDeclarationRule/Failure/function-with-nullable-union-return-type-declaration.php',
-        'Functions/NoParameterWithNullableTypeDeclarationRule/Failure/function-with-parameter-with-nullable-union-type-declaration.php',
+        'Closures/NoNullableReturnTypeDeclarationRule/script.php',
+        'Closures/NoParameterWithNullableTypeDeclarationRule/script.php',
+        'Functions/NoNullableReturnTypeDeclarationRule/script.php',
+        'Functions/NoParameterWithNullableTypeDeclarationRule/script.php',
         'Methods/NoNullableReturnTypeDeclarationRule/Failure/MethodInAnonymousClassWithNullableUnionReturnTypeDeclaration.php',
         'Methods/NoNullableReturnTypeDeclarationRule/Failure/MethodInClassWithNullableUnionReturnTypeDeclaration.php',
         'Methods/NoNullableReturnTypeDeclarationRule/Failure/MethodInInterfaceWithNullableUnionReturnTypeDeclaration.php',

diff --git a/composer.json b/composer.json
@@ -38,6 +38,7 @@
     "phpstan/phpstan-strict-rules": "^1.6.1",
     "phpunit/phpunit": "^9.6.21",
     "psr/container": "^2.0.2",
+    "symfony/finder": "^5.4.45",
     "symfony/process": "^5.4.47"
   },
   "autoload": {

diff --git a/composer.lock b/composer.lock
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -20,3 +20,33 @@ parameters:
 			count: 1
 			path: src/Functions/NoNullableReturnTypeDeclarationRule.php
 
+		-
+			message: "#^Class Ergebnis\\\\PHPStan\\\\Rules\\\\Test\\\\Integration\\\\Methods\\\\FinalInAbstractClassRuleTest extends deprecated class Ergebnis\\\\PHPStan\\\\Rules\\\\Test\\\\Integration\\\\AbstractTestCase\\.$#"
+			count: 1
+			path: test/Integration/Methods/FinalInAbstractClassRuleTest.php
+
+		-
+			message: "#^Class Ergebnis\\\\PHPStan\\\\Rules\\\\Test\\\\Integration\\\\Methods\\\\NoConstructorParameterWithDefaultValueRuleTest extends deprecated class Ergebnis\\\\PHPStan\\\\Rules\\\\Test\\\\Integration\\\\AbstractTestCase\\.$#"
+			count: 1
+			path: test/Integration/Methods/NoConstructorParameterWithDefaultValueRuleTest.php
+
+		-
+			message: "#^Class Ergebnis\\\\PHPStan\\\\Rules\\\\Test\\\\Integration\\\\Methods\\\\NoNullableReturnTypeDeclarationRuleTest extends deprecated class Ergebnis\\\\PHPStan\\\\Rules\\\\Test\\\\Integration\\\\AbstractTestCase\\.$#"
+			count: 1
+			path: test/Integration/Methods/NoNullableReturnTypeDeclarationRuleTest.php
+
+		-
+			message: "#^Class Ergebnis\\\\PHPStan\\\\Rules\\\\Test\\\\Integration\\\\Methods\\\\NoParameterWithContainerTypeDeclarationRuleTest extends deprecated class Ergebnis\\\\PHPStan\\\\Rules\\\\Test\\\\Integration\\\\AbstractTestCase\\.$#"
+			count: 1
+			path: test/Integration/Methods/NoParameterWithContainerTypeDeclarationRuleTest.php
+
+		-
+			message: "#^Class Ergebnis\\\\PHPStan\\\\Rules\\\\Test\\\\Integration\\\\Methods\\\\NoParameterWithNullDefaultValueRuleTest extends deprecated class Ergebnis\\\\PHPStan\\\\Rules\\\\Test\\\\Integration\\\\AbstractTestCase\\.$#"
+			count: 1
+			path: test/Integration/Methods/NoParameterWithNullDefaultValueRuleTest.php
+
+		-
+			message: "#^Class Ergebnis\\\\PHPStan\\\\Rules\\\\Test\\\\Integration\\\\Methods\\\\NoParameterWithNullableTypeDeclarationRuleTest extends deprecated class Ergebnis\\\\PHPStan\\\\Rules\\\\Test\\\\Integration\\\\AbstractTestCase\\.$#"
+			count: 1
+			path: test/Integration/Methods/NoParameterWithNullableTypeDeclarationRuleTest.php
+
diff --git a/test/Fixture/Classes/FinalRule/AbstractClass.php b/test/Fixture/Classes/FinalRule/AbstractClass.php
@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
+
+abstract class AbstractClass
+{
+}
diff --git a/test/Fixture/Classes/FinalRule/ExampleInterface.php b/test/Fixture/Classes/FinalRule/ExampleInterface.php
@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
+
+interface ExampleInterface
+{
+}
diff --git a/test/Fixture/Classes/FinalRule/ExampleTrait.php b/test/Fixture/Classes/FinalRule/ExampleTrait.php
@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
+
+trait ExampleTrait
+{
+}
diff --git a/test/Fixture/Classes/FinalRule/Failure/AbstractClass.php b/test/Fixture/Classes/FinalRule/Failure/AbstractClass.php
diff --git a/test/Fixture/Classes/FinalRule/FinalClass.php b/test/Fixture/Classes/FinalRule/FinalClass.php
@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
+
+final class FinalClass
+{
+}
diff --git a/.../Success/FinalClassWithAnonymousClass.php → ...inalRule/FinalClassWithAnonymousClass.php b/.../Success/FinalClassWithAnonymousClass.php → ...inalRule/FinalClassWithAnonymousClass.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule\Success;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 final class FinalClassWithAnonymousClass
 {

diff --git a/.../Failure/NeitherAbstractNorFinalClass.php → ...inalRule/NeitherAbstractNorFinalClass.php b/.../Failure/NeitherAbstractNorFinalClass.php → ...inalRule/NeitherAbstractNorFinalClass.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule\Failure;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 class NeitherAbstractNorFinalClass
 {

diff --git a/...nalClassWithAliasedOrmEntityAttribute.php → ...nalClassWithAliasedOrmEntityAttribute.php b/...nalClassWithAliasedOrmEntityAttribute.php → ...nalClassWithAliasedOrmEntityAttribute.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRuleWithAttributes\Success;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 use Doctrine\ORM\Mapping as ORM;
 

diff --git a/...sWithEntityAnnotationInInlineDocBlock.php → ...sWithEntityAnnotationInInlineDocBlock.php b/...sWithEntityAnnotationInInlineDocBlock.php → ...sWithEntityAnnotationInInlineDocBlock.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule\Success;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 /** @Entity */
 class NonFinalClassWithEntityAnnotationInInlineDocBlock

diff --git a/...thEntityAnnotationInMultilineDocBlock.php → ...thEntityAnnotationInMultilineDocBlock.php b/...thEntityAnnotationInMultilineDocBlock.php → ...thEntityAnnotationInMultilineDocBlock.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule\Success;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 /**
  * @Table(name="hmm")

diff --git a/...thOrmEntityAnnotationInInlineDocBlock.php → ...thOrmEntityAnnotationInInlineDocBlock.php b/...thOrmEntityAnnotationInInlineDocBlock.php → ...thOrmEntityAnnotationInInlineDocBlock.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule\Success;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 /** @ORM\Entity */
 class NonFinalClassWithOrmEntityAnnotationInInlineDocBlock

diff --git a/...rmEntityAnnotationInMultilineDocBlock.php → ...rmEntityAnnotationInMultilineDocBlock.php b/...rmEntityAnnotationInMultilineDocBlock.php → ...rmEntityAnnotationInMultilineDocBlock.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule\Success;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 /**
  * @ORM\Table(name="hmm")

diff --git a/...ppingEntityAnnotationInInlineDocBlock.php → ...ppingEntityAnnotationInInlineDocBlock.php b/...ppingEntityAnnotationInInlineDocBlock.php → ...ppingEntityAnnotationInInlineDocBlock.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule\Success;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 /** @ORM\Mapping\Entity */
 class NonFinalClassWithOrmMappingEntityAnnotationInInlineDocBlock

diff --git a/...ngEntityAnnotationInMultilineDocBlock.php → ...ngEntityAnnotationInMultilineDocBlock.php b/...ngEntityAnnotationInMultilineDocBlock.php → ...ngEntityAnnotationInMultilineDocBlock.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule\Success;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 /**
  * @ORM\Mapping\Table(name="hmm")

diff --git a/...fiedDoctrineOrmMappingEntityAttribute.php → ...fiedDoctrineOrmMappingEntityAttribute.php b/...fiedDoctrineOrmMappingEntityAttribute.php → ...fiedDoctrineOrmMappingEntityAttribute.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRuleWithAttributes\Success;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 #[\Doctrine\ORM\Mapping\Entity()]
 class NonFinalClassWithQualifiedDoctrineOrmMappingEntityAttribute

diff --git a/...inalClassWithQualifiedEntityAttribute.php → ...inalClassWithQualifiedEntityAttribute.php b/...inalClassWithQualifiedEntityAttribute.php → ...inalClassWithQualifiedEntityAttribute.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRuleWithAttributes\Success;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 use Doctrine\ORM\Mapping\Entity;
 

diff --git a/...ssWithQualifiedMappingEntityAttribute.php → ...ssWithQualifiedMappingEntityAttribute.php b/...ssWithQualifiedMappingEntityAttribute.php → ...ssWithQualifiedMappingEntityAttribute.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRuleWithAttributes\Success;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 use Doctrine\ORM\Mapping;
 

diff --git a/...ithQualifiedOrmMappingEntityAttribute.php → ...ithQualifiedOrmMappingEntityAttribute.php b/...ithQualifiedOrmMappingEntityAttribute.php → ...ithQualifiedOrmMappingEntityAttribute.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRuleWithAttributes\Success;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 use Doctrine\ORM;
 

diff --git a/...fiedDoctrineOrmMappingEntityAttribute.php → ...fiedDoctrineOrmMappingEntityAttribute.php b/...fiedDoctrineOrmMappingEntityAttribute.php → ...fiedDoctrineOrmMappingEntityAttribute.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRuleWithAttributes\Failure;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 #[Doctrine\ORM\Mapping\Entity()]
 class NonFinalClassWithUnqualifiedDoctrineOrmMappingEntityAttribute

diff --git a/...alClassWithUnqualifiedEntityAttribute.php → ...alClassWithUnqualifiedEntityAttribute.php b/...alClassWithUnqualifiedEntityAttribute.php → ...alClassWithUnqualifiedEntityAttribute.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRuleWithAttributes\Failure;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 #[Entity()]
 class NonFinalClassWithUnqualifiedEntityAttribute

diff --git a/...lassWithUnqualifiedOrmEntityAttribute.php → ...lassWithUnqualifiedOrmEntityAttribute.php b/...lassWithUnqualifiedOrmEntityAttribute.php → ...lassWithUnqualifiedOrmEntityAttribute.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRuleWithAttributes\Failure;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 #[ORM\Entity()]
 class NonFinalClassWithUnqualifiedOrmEntityAttribute

diff --git a/...hUnqualifiedOrmMappingEntityAttribute.php → ...hUnqualifiedOrmMappingEntityAttribute.php b/...hUnqualifiedOrmMappingEntityAttribute.php → ...hUnqualifiedOrmMappingEntityAttribute.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRuleWithAttributes\Failure;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 #[ORM\Mapping\Entity()]
 class NonFinalClassWithUnqualifiedOrmMappingEntityAttribute

diff --git a/...thoutEntityAnnotationInInlineDocBlock.php → ...thoutEntityAnnotationInInlineDocBlock.php b/...thoutEntityAnnotationInInlineDocBlock.php → ...thoutEntityAnnotationInInlineDocBlock.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule\Failure;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 /** @eNtItY */
 class NonFinalClassWithoutEntityAnnotationInInlineDocBlock

diff --git a/...utEntityAnnotationInMultilineDocBlock.php → ...utEntityAnnotationInMultilineDocBlock.php b/...utEntityAnnotationInMultilineDocBlock.php → ...utEntityAnnotationInMultilineDocBlock.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule\Failure;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 /**
  * @Table(name="hmm")

diff --git a/...utOrmEntityAnnotationInInlineDocBlock.php → ...utOrmEntityAnnotationInInlineDocBlock.php b/...utOrmEntityAnnotationInInlineDocBlock.php → ...utOrmEntityAnnotationInInlineDocBlock.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule\Failure;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 /** @OrM\eNtItY */
 class NonFinalClassWithoutOrmEntityAnnotationInInlineDocBlock

diff --git a/...rmEntityAnnotationInMultilineDocBlock.php → ...rmEntityAnnotationInMultilineDocBlock.php b/...rmEntityAnnotationInMultilineDocBlock.php → ...rmEntityAnnotationInMultilineDocBlock.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule\Failure;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 /**
  * @ORM\Table(name="hmm")

diff --git a/test/Fixture/Classes/FinalRule/Success/ExampleInterface.php b/test/Fixture/Classes/FinalRule/Success/ExampleInterface.php
diff --git a/test/Fixture/Classes/FinalRule/Success/ExampleTrait.php b/test/Fixture/Classes/FinalRule/Success/ExampleTrait.php
diff --git a/test/Fixture/Classes/FinalRule/Success/FinalClass.php b/test/Fixture/Classes/FinalRule/Success/FinalClass.php
diff --git a/...lRule/Success/TraitWithAnonymousClass.php → ...ses/FinalRule/TraitWithAnonymousClass.php b/...lRule/Success/TraitWithAnonymousClass.php → ...ses/FinalRule/TraitWithAnonymousClass.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule\Success;
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Classes\FinalRule;
 
 trait TraitWithAnonymousClass
 {

diff --git a/...ses/FinalRule/Success/anonymous-class.php → test/Fixture/Classes/FinalRule/script.php b/...ses/FinalRule/Success/anonymous-class.php → test/Fixture/Classes/FinalRule/script.php
diff --git a/test/Fixture/Classes/FinalRuleWithAbstractClassesAllowed/Failure/AbstractClass.php b/test/Fixture/Classes/FinalRuleWithAbstractClassesAllowed/Failure/AbstractClass.php
diff --git a/...ture/Classes/FinalRuleWithAbstractClassesAllowed/Failure/NeitherAbstractNorFinalClass.php b/...ture/Classes/FinalRuleWithAbstractClassesAllowed/Failure/NeitherAbstractNorFinalClass.php
diff --git a/test/Fixture/Classes/FinalRuleWithAbstractClassesAllowed/Success/ExampleInterface.php b/test/Fixture/Classes/FinalRuleWithAbstractClassesAllowed/Success/ExampleInterface.php
diff --git a/test/Fixture/Classes/FinalRuleWithAbstractClassesAllowed/Success/ExampleTrait.php b/test/Fixture/Classes/FinalRuleWithAbstractClassesAllowed/Success/ExampleTrait.php