Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Exclude interfaces from analysis by Methods\FinalInAbstractClassRule #132

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Fix: Exclude interfaces from analysis by Methods\FinalInAbstractClassRule #132

merged 2 commits into from
Sep 16, 2019

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Sep 16, 2019 •
edited
Loading

This PR

  • asserts that an error is not reported by the Methods\FinalInAbstractClassRule for a public method in an interface
  • excludes interfaces from analysis by the Methods\FinalInAbstractClassRule

Follows #123.
Fixes #131.

@localheinz localheinz added the bug label Sep 16, 2019
@localheinz localheinz self-assigned this Sep 16, 2019
@localheinz localheinz merged commit 5c0be9c into master Sep 16, 2019
@localheinz localheinz deleted the fix/interface branch September 16, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@localheinz localheinz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FinalInAbstractClassRule complains not final method in interface
1 participant
@localheinz