Enhancement: Implement Methods\FinalInAbstractClassRule #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
============================================
- Coverage 84.28% 83.88% -0.41%
- Complexity 118 125 +7
============================================
Files 20 21 +1
Lines 401 422 +21
============================================
+ Hits 338 354 +16
- Misses 63 68 +5
Continue to review full report at Codecov.
|
OskarStark
reviewed
Sep 13, 2019
|
|
||
| abstract class AbstractClassWithPublicMethod | ||
| { | ||
| protected function method(): void |
There was a problem hiding this comment.
Thank you, @OskarStark!
OskarStark
reviewed
Sep 13, 2019
README.md
Outdated
|
|
||
| ```neon | ||
| parameters: | ||
| allowAbstractClasses: true |
There was a problem hiding this comment.
Thank you for taking a look, but yes, it's correct - it's the same parameter that is currently used by Localheinz\PHPStan\Rules\Classes\FinalRule, see rules.neon.
On the other hand, perhaps the parameter is not even needed.
localheinz
force-pushed
the
feature/methods-final-in-abstract-class-rule
branch
4 times, most recently
from
d7177d3 to
7ed2763
Compare
localheinz
force-pushed
the
feature/methods-final-in-abstract-class-rule
branch
from
c8d37a4 to
4b1ed80
Compare
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Methods\FinalInAbstractClassRule, which reports an error when a concretepublicorprotectedmethod in anabstractclass is notfinalabstractclass asfinalFixes #88.