Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved solution, fipname option (#370) #748

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Improved solution, fipname option (#370) #748

merged 4 commits into from
Oct 4, 2024

Conversation

lilbe66
Copy link
Contributor

@lilbe66 lilbe66 commented Oct 3, 2024

Resolves #370

@lilbe66 lilbe66 requested a review from alifbe October 3, 2024 11:54
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.85%. Comparing base (0ced59d) to head (8cb59ce).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/subscript/prtvol2csv/prtvol2csv.py 80.76% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
- Coverage   85.92%   85.85%   -0.08%     
==========================================
  Files          51       52       +1     
  Lines        6843     7245     +402     
==========================================
+ Hits         5880     6220     +340     
- Misses        963     1025      +62

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lilbe66 lilbe66 requested a review from rnyb October 4, 2024 06:56
rnyb
rnyb reviewed Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@rnyb rnyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

docs/scripts/prtvol2csv.rst Show resolved Hide resolved
src/subscript/config_jobs/PRTVOL2CSV Outdated Show resolved Hide resolved
src/subscript/prtvol2csv/prtvol2csv.py Outdated Show resolved Hide resolved
src/subscript/prtvol2csv/prtvol2csv.py Outdated Show resolved Hide resolved
src/subscript/config_jobs/PRTVOL2CSV Outdated Show resolved Hide resolved
@lilbe66 lilbe66 requested a review from rnyb October 4, 2024 13:26
rnyb
rnyb approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@rnyb rnyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilbe66 lilbe66 merged commit 107d6d1 into equinor:main Oct 4, 2024
6 checks passed
@lilbe66 lilbe66 deleted the prtvol2csv_fipxxx_v2 branch October 4, 2024 13:40
@lilbe66 lilbe66 mentioned this pull request Oct 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnyb rnyb rnyb approved these changes

@alifbe alifbe Awaiting requested review from alifbe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[prtvol2csv] Support for more than FIPNUM
3 participants
@lilbe66 @codecov-commenter @rnyb