New fipname option #713
Closed
New fipname option #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilbe66
force-pushed
the
prtvol2csv_fipxxx
branch
from
9b8e890 to
7ed0e9b
Compare
mferrera
reviewed
Jun 21, 2024
Comment on lines
+188
to
+190
| expected = pd.DataFrame.from_dict( | ||
| { | ||
| "FIPNUM": { |
There was a problem hiding this comment.
Is checking a smaller sample of these values sufficient to validate?
There was a problem hiding this comment.
Will discuss with Alif
lilbe66
force-pushed
the
prtvol2csv_fipxxx
branch
from
7ed0e9b to
cd78a43
Compare
|
Merged in PR #748 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #370 . Added an new option in prtvol2csv (--fipname) to be able to extract volumes from the Eclipse PRT file for a selected FIP-vector.