-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supply Kit and Return Kit- Consistency check and force uppercase- Biospecimen (September release) #1089
Supply Kit and Return Kit- Consistency check and force uppercase- Biospecimen (September release) #1089
Comments
To be clear, is this ticket also requesting that we add validation to ensure that the Supply Kit ID and Return Kit ID match? If so, should similar validation be added for the Cup ID and Card ID, and is any other validation (such as comparing the beginning of the Cup ID/Card ID and Supply Kit ID/Return Kit ID) needed? |
@amber-emmes, yes, please add the same validation to Cup ID and Card. I just tested and the despite presenting the error messaging, the system does allow kit assembly to occur when the Cup and Card IDs don't match: |
Both the front end and back end work enforcing this validation are in dev and ready to be tested. |
@amber-emmes Thanks for the update, beginning Dev testing now, I will update here when complete. |
@amber-emmes This is looking pretty good.
-System is also prohibiting Kit Assembly when Cup and Card IDs don't match. Is there any way to get the error message to go away when the FNL team member removes the mismatching information? Or will this persist until they click the X to close the error message? The presence of this error message, even when the correct information is entered may be confusing: |
Currently, the error message will persist until the x is clicked. I am not aware of any other way to close it. |
We will inform the FNL team that they need to close the error message by clicking the X. This is ready for Stage. |
Tested in Stage, Ready for Prod
|
Our QC report recently flagged a case where the Return Kit ID was entered into the Dashboard with lower case "c" and the Supply Kit was entered with uppercase "C," thus the two did not match.
Please update programming to force all alpha characters to uppercase, even if entered in lowercase.
Also, please note in re-creating this issue in Dev, it looks like even when the error message appears due to the case sensitivity, the system still allows you to move forward, when clicking "Save & Next" and creates the kits with the mismatched IDs
I also tested this scenario and found the same when using completely different Supply Kit and Return Kit IDs.
The text was updated successfully, but these errors were encountered: