Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply Kit and Return Kit- Consistency check and force uppercase- Biospecimen (September release) #1089

Closed
erincschwartz opened this issue Aug 6, 2024 · 8 comments · Fixed by NCI-C4CP/connectFaas#642 or NCI-C4CP/biospecimen#734
Assignees
Labels
CCC Priority 1 Issues to be addressed in the current release

Comments

@erincschwartz
Copy link
Collaborator

Our QC report recently flagged a case where the Return Kit ID was entered into the Dashboard with lower case "c" and the Supply Kit was entered with uppercase "C," thus the two did not match.

Please update programming to force all alpha characters to uppercase, even if entered in lowercase.

Also, please note in re-creating this issue in Dev, it looks like even when the error message appears due to the case sensitivity, the system still allows you to move forward, when clicking "Save & Next" and creates the kits with the mismatched IDs

Image

Image

I also tested this scenario and found the same when using completely different Supply Kit and Return Kit IDs.

Image

Image

@erincschwartz erincschwartz converted this from a draft issue Aug 6, 2024
@erincschwartz erincschwartz changed the title Supply Kit and Return Kit- Consistency check and force uppercase- Biospecimens Supply Kit and Return Kit- Consistency check and force uppercase- Biospecimen (Sept) Aug 6, 2024
@sonyekere sonyekere added the CCC Priority 2 Issues will be prioritized in the upcoming/next release label Aug 7, 2024
@erincschwartz erincschwartz changed the title Supply Kit and Return Kit- Consistency check and force uppercase- Biospecimen (Sept) Supply Kit and Return Kit- Consistency check and force uppercase- Biospecimen (September release) Aug 7, 2024
@amber-emmes
Copy link
Collaborator

amber-emmes commented Aug 20, 2024

To be clear, is this ticket also requesting that we add validation to ensure that the Supply Kit ID and Return Kit ID match? If so, should similar validation be added for the Cup ID and Card ID, and is any other validation (such as comparing the beginning of the Cup ID/Card ID and Supply Kit ID/Return Kit ID) needed?

@erincschwartz
Copy link
Collaborator Author

@amber-emmes, yes, please add the same validation to Cup ID and Card. I just tested and the despite presenting the error messaging, the system does allow kit assembly to occur when the Cup and Card IDs don't match:

Image

@amber-emmes
Copy link
Collaborator

Both the front end and back end work enforcing this validation are in dev and ready to be tested.

@erincschwartz
Copy link
Collaborator Author

@amber-emmes Thanks for the update, beginning Dev testing now, I will update here when complete.

@erincschwartz
Copy link
Collaborator Author

@amber-emmes This is looking pretty good.

  • Confirmed that even when entering lowercase characters (ch and cha), the system now forces them to be uppercase
  • System is now prohibiting Kit Assembly when Supply Kit and Return Kit IDs don't match

image

-System is also prohibiting Kit Assembly when Cup and Card IDs don't match.

image

Is there any way to get the error message to go away when the FNL team member removes the mismatching information? Or will this persist until they click the X to close the error message?

image

The presence of this error message, even when the correct information is entered may be confusing:
image

@amber-emmes
Copy link
Collaborator

Currently, the error message will persist until the x is clicked. I am not aware of any other way to close it.

@erincschwartz
Copy link
Collaborator Author

We will inform the FNL team that they need to close the error message by clicking the X.

This is ready for Stage.

@erincschwartz
Copy link
Collaborator Author

Tested in Stage, Ready for Prod

  • Confirmed that even when entering lowercase characters (ch and cha), the system now forces them to be uppercase in Stage
  • System is now prohibiting Kit Assembly when Supply Kit and Return Kit IDs don't match in Stage
  • System is also prohibiting Kit Assembly when Cup and Card IDs don't match in Stage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCC Priority 1 Issues to be addressed in the current release
Projects
3 participants