Kit assembly now enforces uppercase and checks for matching ID numbers #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amber-emmes
requested review from
anthonypetersen and
Gbarra9
and removed request for
a team
amber-emmes
changed the title
| const validateKitAssemblyData = (data) => { | ||
| // Ensure that values are uppercase and that the appropriate values match | ||
| if(data[fieldMapping.returnKitId]) { | ||
| data[fieldMapping.returnKitId] = ('' + data[fieldMapping.returnKitId]).toUpperCase(); |
There was a problem hiding this comment.
What is the purpose of adding the empty strings in all these statements?
There was a problem hiding this comment.
I do it to make 100% sure it's a string before running toUpperCase, in case we end up with a number.
anthonypetersen
approved these changes
Sep 9, 2024
Gbarra9
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides back-end enforcement of changes requested by 1089.