Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uppercase transformation + kit numbers validation added (1089) #734

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

amber-emmes
Copy link
Collaborator

As per 1089.

@amber-emmes amber-emmes requested review from a team September 9, 2024 17:15
@amber-emmes amber-emmes self-assigned this Sep 9, 2024
@amber-emmes amber-emmes requested review from we-ai and jhflorey and removed request for a team September 9, 2024 17:15
@jhflorey
Copy link
Collaborator

Looks good

Copy link
Collaborator

@we-ai we-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Commented on minor things.

src/shared.js Outdated Show resolved Hide resolved
src/pages/homeCollection/kitAssembly.js Outdated Show resolved Hide resolved
@amber-emmes amber-emmes merged commit 16b6a3f into dev Sep 10, 2024
@amber-emmes amber-emmes deleted the 1089-fix branch September 10, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supply Kit and Return Kit- Consistency check and force uppercase- Biospecimen (September release)
3 participants