Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5659 - Moving of selected microstructures on macro canvas works wrong #5769

Merged
merged 2 commits into from
Oct 17, 2024
Merged

#5659 - Moving of selected microstructures on macro canvas works wrong #5769

merged 2 commits into from
Oct 17, 2024

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Oct 15, 2024 •
edited
Loading

How the feature works? / How did you fix the issue?

  • removed hidden chems created for molecules in model from selection
  • fixed performance by collecting moving

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@rrodionov91 rrodionov91 linked an issue Oct 15, 2024 that may be closed by this pull request
Moving of selected microstructures on macro canvas works wrong #5659
Closed
@rrodionov91
#5659 - Moving of selected microstructures on macro canvas works wrong
772f769 
- removed hidden chems created for molecules in model from selection
- fixed performance by collecting moving
@rrodionov91
- fixed redo for movement
42a7d1e
@rrodionov91 rrodionov91 force-pushed the 5659-Moving_of_selected_microstructures_on_macro_canvas_works_wrong branch from a0e1cfb to 42a7d1e Compare October 16, 2024 18:04
@rrodionov91 rrodionov91 merged commit 1b01714 into release/2.26 Oct 17, 2024
3 checks passed
@rrodionov91 rrodionov91 deleted the 5659-Moving_of_selected_microstructures_on_macro_canvas_works_wrong branch October 17, 2024 14:59
rrodionov91 added a commit that referenced this pull request Oct 18, 2024
@rrodionov91
#5659 - Moving of selected microstructures on macro canvas works wrong (
a4eee96 
#5769)

- removed hidden chems created for molecules in model from selection
- fixed performance by collecting moving
svvald pushed a commit that referenced this pull request Oct 21, 2024
@rrodionov91
#5659 - Moving of selected microstructures on macro canvas works wrong (
ba82bf0 
#5769) (#5820)

- removed hidden chems created for molecules in model from selection
- fixed performance by collecting moving
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svvald svvald svvald approved these changes

@AlexeyGirin AlexeyGirin Awaiting requested review from AlexeyGirin

@NataliaLoginova NataliaLoginova Awaiting requested review from NataliaLoginova

Assignees

@rrodionov91 rrodionov91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving of selected microstructures on macro canvas works wrong
2 participants
@rrodionov91 @svvald