Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving of selected microstructures on macro canvas works wrong #5659

Closed
AlexeyGirin opened this issue Oct 7, 2024 · 1 comment · Fixed by #5769 or #5820
Closed

Moving of selected microstructures on macro canvas works wrong #5659

AlexeyGirin opened this issue Oct 7, 2024 · 1 comment · Fixed by #5769 or #5820
Assignees
@rrodionov91
Labels
Micro-Macro Bucket: Bugs related to Micro structures on Macro mode Priority: Medium
Milestone
Ketcher 2.26.0-rc.4

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Go to Macro mode - Flex
  2. Load from file: Bond properties are not implemented.zip
    image
  3. Select all (press Ctrl+A)
  4. Drag any Atom and move it

Actual behavior
Only atoms are moved (some labels got lost)
image

Expected behavior
Movement works fine

Versions

  • Ketcher Version 2.26.0-rc.1 Build at 2024-10-04; 18:45:04
  • Indigo Toolkit Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.90 (Official Build) (64-bit)
  • Win10

Issue found while testing: #5359
@AlexeyGirin AlexeyGirin added bug Priority: Medium Micro-Macro Bucket: Bugs related to Micro structures on Macro mode labels Oct 7, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.26.0-rc.2 milestone Oct 7, 2024
@rrodionov91 rrodionov91 self-assigned this Oct 15, 2024
rrodionov91 added a commit that referenced this issue Oct 15, 2024
@rrodionov91
#5659 - Moving of selected microstructures on macro canvas works wrong
a0e1cfb 
- removed hidden chems created for molecules in model from selection
- fixed performance by collecting moving
@rrodionov91 rrodionov91 linked a pull request Oct 15, 2024 that will close this issue
#5659 - Moving of selected microstructures on macro canvas works wrong #5769
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Oct 16, 2024
@rrodionov91
#5659 - Moving of selected microstructures on macro canvas works wrong
772f769 
- removed hidden chems created for molecules in model from selection
- fixed performance by collecting moving
rrodionov91 added a commit that referenced this issue Oct 17, 2024
@rrodionov91
#5659 - Moving of selected microstructures on macro canvas works wrong (
1b01714 
#5769)

- removed hidden chems created for molecules in model from selection
- fixed performance by collecting moving
rrodionov91 added a commit that referenced this issue Oct 18, 2024
@rrodionov91
#5659 - Moving of selected microstructures on macro canvas works wrong (
a4eee96 
#5769)

- removed hidden chems created for molecules in model from selection
- fixed performance by collecting moving
@rrodionov91 rrodionov91 linked a pull request Oct 18, 2024 that will close this issue
Backmerge: #5659 - Moving of selected microstructures on macro canvas works wrong #5820
Merged
9 tasks
svvald pushed a commit that referenced this issue Oct 21, 2024
@rrodionov91
#5659 - Moving of selected microstructures on macro canvas works wrong (
ba82bf0 
#5769) (#5820)

- removed hidden chems created for molecules in model from selection
- fixed performance by collecting moving
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image

  • Ketcher Version 2.26.0-rc.4 Build at 2024-10-18; 17:00:39
  • Indigo Toolkit Version 1.25.0-rc.2.0-g867ae250b-wasm32-wasm-clang-19.0.0
  • Chrome Version 130.0.6723.59 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
Micro-Macro Bucket: Bugs related to Micro structures on Macro mode Priority: Medium
Projects
None yet
Milestone
Ketcher 2.26.0-rc.4
2 participants
@rrodionov91 @AlexeyGirin