Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backmerge: #5245 - Replacement of peptide at the end of sequence on preset w/out base works wrong #5278

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Aug 12, 2024

How the feature works? / How did you fix the issue?

  • moved rna node addition in sequence mode to separate function
  • removed restriction of insertion/replacing rna without base

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

… base works wrong

- moved rna node addition in sequence mode to separate function
- removed restriction of insertion/replacing rna without base
@rrodionov91 rrodionov91 merged commit 6b6546e into master Aug 12, 2024
5 checks passed
@rrodionov91 rrodionov91 deleted the 5245-replace-to-rna-without-base-master branch August 12, 2024 13:20
Guch1g0v pushed a commit that referenced this pull request Oct 17, 2024
…reset w/out base works wrong (#5278)

- moved rna node addition in sequence mode to separate function
- removed restriction of insertion/replacing rna without base
- fixed conditions sequence in rna addition method for sequence mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment