Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement of preset at the end of sequence on preset w/out base works wrong #5248

Closed
AlexeyGirin opened this issue Aug 8, 2024 · 1 comment · Fixed by #5274 or #5278
Closed

Replacement of preset at the end of sequence on preset w/out base works wrong #5248

AlexeyGirin opened this issue Aug 8, 2024 · 1 comment · Fixed by #5274 or #5278
Assignees
Labels
Monomer Library Priority: Medium Sequence mode Bucket: Sequence mode related issues

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Aug 8, 2024

Steps to Reproduce

  1. Go to Macromolecules mode - Sequence mode
  2. Load from file: Uploading Replacement of preset at the end of sequence on preset wout base works wrong.zip…
    image
  3. Create custom preset without base and name it "No base"
    image
  4. Select last monomer (in view mode)
    image
  5. Click on "No preset" preset in the library

Actual behavior
"Confirm Your Actions" dialog appears
image
Click YES
System replace A preset with p phosphate
image

Expected behavior
No dialog appears
System replace A preset with @ symbol
image

As per requirement:

  1. If the user selects any number of monomers in view mode, and clicks on the monomer card in the library, all selected monomer on the canvas are replaced by chosen monomer from the library each

Versions

  • Ketcher Version 2.24.0-rc.1 Build at 2024-08-06; 19:17:47
  • Indigo Toolkit Version 1.23.0-rc.1.0-g85f89b8f5-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)

Related issue - #4878

@AlexeyGirin
Copy link
Collaborator Author

Fixed.
image

  • Ketcher Version 2.24.0-rc.2 Build at 2024-08-14; 19:00:14
  • Indigo Toolkit Version 1.23.0-rc.2.0-g6a2a7526a-wasm32-wasm-clang-19.0.0
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment