Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4801 - Cut operation for attachment points makes canvas inaccessible/inoperational and delete entire molecule #4815

Merged

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Jun 7, 2024

How the feature works? / How did you fix the issue?

  • added skipping of implicit leaving group atom deletion in case if it is explicitly selected
  • added connected atoms invalidation for undo of bond deletion
  • skipped regular logic of sgroup atoms deletion in case of superatoms without labels

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

…/inoperational and delete entire molecule

- added skipping of implicit leaving group atom deletion in case if it is explicitly selected
- added connected atoms invalidation for undo of bond deletion
- skipped regular logic of sgroup atoms deletion in case of superatoms without labels
@rrodionov91 rrodionov91 merged commit fc7d5cf into master Jun 7, 2024
5 checks passed
@rrodionov91 rrodionov91 deleted the 4801-cut-molecule-with-connection-to-monomer-backmerge branch June 7, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cut operation for attachment points makes canvas inaccessible/inoperational and delete entire molecule
2 participants