Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut operation for attachment points makes canvas inaccessible/inoperational and delete entire molecule #4801

Closed
AlexeyGirin opened this issue Jun 6, 2024 · 1 comment · Fixed by #4811 or #4815
Closed

Cut operation for attachment points makes canvas inaccessible/inoperational and delete entire molecule #4801

AlexeyGirin opened this issue Jun 6, 2024 · 1 comment · Fixed by #4811 or #4815
Assignees
@rrodionov91
Labels
Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: High
Milestone
Ketcher 2.22.0-rc.3

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Load from file: Cut operation for attachment points makes canvas inaccessible and delete entire molecule2.zip
    OR manually create following configuration on the canvas:
    image
  2. Select few atoms and at least one attachment point
    image
  3. Press CTRL+X key

Actual behavior
Entire molecule disappears
image
Canvas become inaccessible and inoperational (try to select the rest molecule)

Expected behavior
Only selected elements disappears
image
Canvas remain accessible and operational for user

Versions:

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-03; 18:43:00
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

Issue found while testing #4530
@AlexeyGirin AlexeyGirin added bug Priority: High Micromolecules canvas Bucket: Micromolecules canvas related issues labels Jun 6, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.22.0-rc.3 milestone Jun 6, 2024
@rrodionov91 rrodionov91 self-assigned this Jun 7, 2024
rrodionov91 added a commit that referenced this issue Jun 7, 2024
@rrodionov91
#4801 - Cut operation for attachment points makes canvas inaccessible…
0f8474b 
…/inoperational and delete entire molecule

- added skipping of implicit leaving group atom deletion in case if it is explicitly selected
- added connected atoms invalidation for undo of bond deletion
- skipped regular logic of sgroup atoms deletion in case of superatoms without labels
@rrodionov91 rrodionov91 linked a pull request Jun 7, 2024 that will close this issue
#4801 - Cut operation for attachment points makes canvas inaccessible/inoperational and delete entire molecule #4811
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 7, 2024
@rrodionov91
#4801 - Cut operation for attachment points makes canvas inaccessible…
b355328 
…/inoperational and delete entire molecule

- added skipping of implicit leaving group atom deletion in case if it is explicitly selected
- added connected atoms invalidation for undo of bond deletion
- skipped regular logic of sgroup atoms deletion in case of superatoms without labels
@rrodionov91 rrodionov91 linked a pull request Jun 7, 2024 that will close this issue
#4801 - Cut operation for attachment points makes canvas inaccessible/inoperational and delete entire molecule #4815
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 7, 2024
@rrodionov91
#4801 - Cut operation for attachment points makes canvas inaccessible…
f69e9af 
…/inoperational and delete entire molecule (#4811)

- added skipping of implicit leaving group atom deletion in case if it is explicitly selected
- added connected atoms invalidation for undo of bond deletion
- skipped regular logic of sgroup atoms deletion in case of superatoms without labels
rrodionov91 added a commit that referenced this issue Jun 7, 2024
@rrodionov91
#4801 - Cut operation for attachment points makes canvas inaccessible…
fc7d5cf 
…/inoperational and delete entire molecule (#4815)

- added skipping of implicit leaving group atom deletion in case if it is explicitly selected
- added connected atoms invalidation for undo of bond deletion
- skipped regular logic of sgroup atoms deletion in case of superatoms without labels
@Zhirnoff
Copy link
Collaborator

By Erase Tool

2024-06-10_17h15_47.mp4

By CTRL+X

2024-06-10_17h17_07.mp4

Tested. Bug fixed.
Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.3]
Indigo version
[Version 1.21.0-rc.1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: High
Projects
None yet
Milestone
Ketcher 2.22.0-rc.3
3 participants
@rrodionov91 @AlexeyGirin @Zhirnoff