Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backmerge: #4329 macro cyclic chains disappear from canvas when switching to sequence mode #4551

Conversation

baranovdv
Copy link
Contributor

@baranovdv baranovdv commented Apr 29, 2024

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

…nvas-when-switching-to-sequence-mode-backmerge
Comment on lines 95 to 100
this.fillSubChains(
getNextMonomerInChain(
this.lastNode?.lastMonomerInNode,
this.firstMonomer,
),
);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need to keep only this part

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@NataliaLoginova NataliaLoginova merged commit 66e8733 into master May 10, 2024
5 checks passed
@NataliaLoginova NataliaLoginova deleted the 4329-macro-cyclic-chains-disappear-from-canvas-when-switching-to-sequence-mode-backmerge branch May 10, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macro: Cyclic chains disappear from canvas when switching to sequence mode
3 participants