Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4329 - Macro: Cyclic chains disappear from canvas when switching to sequence mode #4426

Conversation

baranovdv
Copy link
Contributor

@baranovdv baranovdv commented Apr 5, 2024

  • add function that handles cycled chains
  • add cycled link drawing
2024-04-05.14.32.40.mov

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@ilya-asiyuk-epam
Copy link
Contributor

My main question:
should we allow and, as a result, display cyclic chain for such case (without P at the end of the chain)?
chain without p
cc: @Zhirnoff

Does current fix support such case?
cc: @baranovdv , @NataliaLoginova

@baranovdv
Copy link
Contributor Author

Does current fix support such case? cc: @baranovdv , @NataliaLoginova

@ilya-asiyuk-epam no, this this case is not supported. I can implement this after desired behavior would be known

@baranovdv
Copy link
Contributor Author

baranovdv commented Apr 8, 2024

Does current fix support such case? cc: @baranovdv , @NataliaLoginova

@ilya-asiyuk-epam no, this this case is not supported. I can implement this after desired behavior would be known

Or maybe it's ok to implement mechanic similar to HELM Editor (Phosphate is added automatically):

HELM.Web.Editor.-.Google.Chrome.2024-04-08.18-25-12.mp4

@NataliaLoginova NataliaLoginova merged commit 2a69be5 into release/2.20 Apr 25, 2024
3 checks passed
@NataliaLoginova NataliaLoginova deleted the 4329-macro-cyclic-chains-disappear-from-canvas-when-switching-to-sequence-mode branch April 25, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macro: Cyclic chains disappear from canvas when switching to sequence mode
4 participants