Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4369 - Del button works as Backspace button that is wrong #4408

Conversation

burcinkarimov
Copy link
Collaborator

@burcinkarimov burcinkarimov commented Apr 4, 2024

How the feature works? / How did you fix the issue?

Backspace and Delete keys both had the same deletion behavior (deleting left node). Since Delete key should remove the right side, according changes were applied to separate their behavior.

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@NataliaLoginova NataliaLoginova merged commit 9af9b98 into release/2.20 Apr 15, 2024
3 checks passed
@NataliaLoginova NataliaLoginova deleted the 4369-del-button-works-as-backspace-button-that-is-wrong branch April 15, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macro: Del button works as Backspace button that is wrong
3 participants