Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Del button works as Backspace button that is wrong #4369

Closed
AlexeyGirin opened this issue Mar 28, 2024 · 2 comments · Fixed by #4408, #4466 or #4469
Closed

Macro: Del button works as Backspace button that is wrong #4369

AlexeyGirin opened this issue Mar 28, 2024 · 2 comments · Fixed by #4408, #4466 or #4469
Assignees
@burcinkarimov
Labels
Macromolecules Priority: High
Milestone
Ketcher 2.20.0-rc.3

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Mar 28, 2024 •
edited
Loading

Steps to Reproduce

  1. Switch to the Macro mode - Sequence mode
  2. Add chains to the canvas (ATUC) and put cursor in the middle
    image
  3. Press Del key

Actual behavior
System removes T (i.e. removes symbol BEFORE cursor - this is how Backspace key works)
image

Expected behavior
System removes U (i.e. removes symbol AFTER cursor - this is how Del key intended to work)
image

Desktop (please complete the following information):

  • OS: Windows 10 Pro (version 22H2) x64
  • Browser: Сhrome Version: (122.0.6261.112) x64
  • Ketcher version 2.20.0-rc.2 Build at 2024-03-27; 08:25:13
  • Indigo Toolkit Version 1.19.0-rc.2.0-g6c0e3fecf-wasm32-wasm-clang-12.0.0

Issue found while testing #3650
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.20.0-rc.3 milestone Mar 28, 2024
burcinkarimov added a commit that referenced this issue Apr 4, 2024
@burcinkarimov
#4369 - Del button works as Backspace button that is wrong
11744ab
@burcinkarimov burcinkarimov linked a pull request Apr 4, 2024 that will close this issue
#4369 - Del button works as Backspace button that is wrong #4408
Merged
9 tasks
@AlexeyGirin AlexeyGirin changed the title Del button works as Backspace button that is wrong Macro: Del button works as Backspace button that is wrong Apr 10, 2024
NataliaLoginova added a commit that referenced this issue Apr 15, 2024
@NataliaLoginova
Merge pull request #4408 from epam/4369-del-button-works-as-backspace…
9af9b98 
…-button-that-is-wrong

#4369 - Del button works as Backspace button that is wrong
burcinkarimov pushed a commit that referenced this issue Apr 16, 2024
@NataliaLoginova @burcinkarimov
Backmerge: #4369 - Del button works as Backspace button that is wrong
d761100
NataliaLoginova added a commit that referenced this issue Apr 16, 2024
@NataliaLoginova
Merge pull request #4466 from epam/4369-del-button-works-as-backspace…
ca3b83f 
…-button-that-is-wrong

Backmerge: #4369 - Del button works as Backspace button that is wrong
@NataliaLoginova NataliaLoginova linked a pull request Apr 16, 2024 that will close this issue
Backmerge: #4369 - Del button works as Backspace button that is wrong #4466
Merged
9 tasks
burcinkarimov pushed a commit that referenced this issue Apr 16, 2024
@NataliaLoginova @burcinkarimov
Backmerge: #4369 - Del button works as Backspace button that is wrong
a6de21e
@NataliaLoginova NataliaLoginova linked a pull request Apr 16, 2024 that will close this issue
Backmerge: #4369 - Del button works as Backspace button that is wrong #4469
Merged
9 tasks
NataliaLoginova added a commit that referenced this issue Apr 16, 2024
@NataliaLoginova
Merge pull request #4469 from epam/4369-del-button-works-as-backspace…
bf6d26c 
…-button-that-is-wrong

Backmerge: #4369 - Del button works as Backspace button that is wrong
@AlexeyGirin
Copy link
Collaborator Author

Not fixed.
Delete button works as Backspace still

@AlexeyGirin AlexeyGirin reopened this Apr 16, 2024
@AlexeyGirin
Copy link
Collaborator Author

Fixed.
image

Ketcher Version 2.20.0-rc.3 Build at 2024-04-26; 16:57:15
Indigo Toolkit Version 1.19.0-rc.3.0-gf2d7689b8-wasm32-wasm-clang-12.0.0

OS: Windows 10
Browser Chrome Version 112.0.5615.138 (Official Build) (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@burcinkarimov burcinkarimov

Labels
Macromolecules Priority: High
Projects
None yet
Milestone
Ketcher 2.20.0-rc.3
4 participants
@NataliaLoginova @rrodionov91 @AlexeyGirin @burcinkarimov