Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3176 – Drawing gets broken after dragging a Functional Group onto an atom #3199

Conversation

Nitvex
Copy link
Collaborator

@Nitvex Nitvex commented Aug 25, 2023

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

if functional group is merged to another atom, then its' AttachmentPoint atom is removed. The problem occured because, atom itself was removed, but attachment point still pointed to deleted atom.

closes #3176

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

…n atom in structure, errors appear in DevTools console
@Nitvex Nitvex linked an issue Aug 25, 2023 that may be closed by this pull request
@Nitvex Nitvex changed the title #3176 – when dragging and dropping an abbreviation of functional group onto an atom in structure errors appear in devtools console n atom in structure, errors appear in DevTools console #3176 – Drawing gets broken after dragging a Functional Group onto an atom Aug 25, 2023
@Nitvex Nitvex merged commit dfb38a0 into release/2.13 Aug 25, 2023
@Nitvex Nitvex deleted the 3176-when-dragging-and-dropping-an-abbreviation-of-functional-group-onto-an-atom-in-structure-errors-appear-in-devtools-console branch August 25, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawing gets broken after dragging a Functional Group onto an atom
2 participants