Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawing gets broken after dragging a Functional Group onto an atom #3176

Closed
Zhirnoff opened this issue Aug 23, 2023 · 1 comment · Fixed by #3199, #3200 or #3201
Closed

Drawing gets broken after dragging a Functional Group onto an atom #3176

Zhirnoff opened this issue Aug 23, 2023 · 1 comment · Fixed by #3199, #3200 or #3201
Assignees
@Nitvex
Milestone
Ketcher 2.13.0-rc.5

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Aug 23, 2023 •
edited
Loading

Steps to Reproduce

  1. Open Ketcher
  2. Add Benzene ring to canvas
  3. Add any Functional Group on canvas
  4. With selection tool drag and drop Functional Group on any Benzene atom

Actual behavior
When dragging and dropping an abbreviation of Functional Group onto an atom in the structure, errors appear in the DevTools console.
Functional Group expands. After that, the user cannot continue to draw structures on the canvas. You can only click the clear canvas and continue to work.

Expected behavior
When dragging and dropping an abbreviation of Functional Group onto an atom in the structure, errors not appear in the DevTools console.
Functional Group abbreviation not expands.

Screenshots

2023-08-23_14h12_21.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.14.0-rc.2
@Zhirnoff Zhirnoff added the bug label Aug 23, 2023
@Zhirnoff Zhirnoff added this to the Ketcher 2.14.0-rc.3 milestone Aug 23, 2023
@vanoprenko vanoprenko changed the title When dragging and dropping an abbreviation of Functional Group onto an atom in structure, errors appear in DevTools console Drawing gets broken after dragging a Functional Group onto an atom Aug 25, 2023
@Nitvex Nitvex mentioned this issue Aug 25, 2023
Merged
9 tasks
@Nitvex Nitvex linked a pull request Aug 25, 2023 that will close this issue
#3176 – Drawing gets broken after dragging a Functional Group onto an atom #3199
Merged
9 tasks
Nitvex added a commit that referenced this issue Aug 25, 2023
@Nitvex
#3176 – Drawing gets broken after dragging a Functional Group onto an…
dfb38a0 
… atom
Nitvex added a commit that referenced this issue Aug 25, 2023
@Nitvex
Backmerge: #3176 – Drawing gets broken after dragging a Functional Gr…
de7b25d 
…oup onto an atom
@Nitvex Nitvex mentioned this issue Aug 25, 2023
Merged
9 tasks
@Nitvex Nitvex linked a pull request Aug 25, 2023 that will close this issue
Backmerge: #3176 – Drawing gets broken after dragging a Functional Group onto an atom #3200
Merged
9 tasks
Nitvex added a commit that referenced this issue Aug 25, 2023
@Nitvex
Backmerge: #3176 – Drawing gets broken after dragging a Functional Gr…
cdf7a81 
…oup onto an atom
@Nitvex Nitvex mentioned this issue Aug 25, 2023
Merged
9 tasks
Nitvex added a commit that referenced this issue Aug 29, 2023
@Nitvex
Backmerge: #3176 – Drawing gets broken after dragging a Functional Gr…
3362818 
…oup onto an atom (#3200)
Nitvex added a commit that referenced this issue Aug 29, 2023
@Nitvex
#3176 – add wait for Indigo init
a2801e2
Nitvex added a commit that referenced this issue Aug 29, 2023
@Nitvex
Backmerge: #3176 – Drawing gets broken after dragging a Functional Gr…
92850a0 
…oup onto an atom (#3201)

* Backmerge: #3176 – Drawing gets broken after dragging a Functional Group onto an atom

* #3176 – add wait for Indigo init
@ViktoriaTkacheva
Copy link
Collaborator

Issues that were not fixed within this task are moved to a separate ticket: #3241

@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

Labels
None yet
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.13.0-rc.5
3 participants
@Nitvex @Zhirnoff @ViktoriaTkacheva