#1902 Save hotkey CTRL+S: An atom or structure copied to the clipboard is saved with coordinates #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
porcelain11
commented
Dec 19, 2022
porcelain11
commented
- Refactor savebutton module to get rid of onSave error
- Update keyHandle function (dispatching change tool action, when paste tool is selected and user pushes ctrl + s)
…le to remove not rendered structure from one to be saved
porcelain11
changed the title
porcelain11
changed the title
epam-nikolai-iakushchenko
approved these changes
Dec 20, 2022
packages/ketcher-react/src/script/ui/component/view/savebutton.tsx
Outdated
Show resolved
Hide resolved
| className={className} | ||
| onClick={(event) => { | ||
| save(event) | ||
| }} | ||
| {...props} | ||
| // TODO: remove this, if it doesn't fire errors - hardly we need all these props |
There was a problem hiding this comment.
Does it make sense to add a follow-up story to remove this? So we don't need additional effort trying to recall if we need these props in the future? Wonder what the team thinks
There was a problem hiding this comment.
If you've worked with this piece of code and understood, what it is used for, then I propose to remove this.
If not, then it is better not to change current behaviour.
Nitvex
requested changes
Dec 28, 2022
…copied-to-clipboard-is-saved-with-coordinates
KonstantinEpam23
approved these changes
Jan 9, 2023
…copied-to-clipboard-is-saved-with-coordinates
Nitvex
changed the title
Nitvex
approved these changes
Jan 10, 2023
Nitvex
deleted the
1902-save-hotkey-ctrl-s-atom-or-structure-copied-to-clipboard-is-saved-with-coordinates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.