Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save hotkey CTRL+S: An atom or structure copied to the clipboard is saved with coordinates #1902

Closed
Zhirnoff opened this issue Dec 9, 2022 · 0 comments · Fixed by #1956
Closed

Save hotkey CTRL+S: An atom or structure copied to the clipboard is saved with coordinates #1902

Zhirnoff opened this issue Dec 9, 2022 · 0 comments · Fixed by #1956
Assignees
@porcelain11
Milestone
Release Candidate...

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Dec 9, 2022

Steps to Reproduce

  1. Open Ketcher
  2. Copy an atom(e.g. Nitrogen) or structure (e.g. Benzene) to the clipboard ( CTRL+C )
  3. Press CTRL+V on canvas
  4. Then without clicking on the canvas - press CTRL+S

Expected behavior
In the save window that opens, in the preview section, the atom or structure has no coordinates because they were not added to the canvas

Actual behavior
In the save window that opens, in the preview section, the atom or structure has coordinates as if they were added to the canvas

Screenshots
Atom copied to clipboard (Nitrogen)
2022-12-09_15h42_59
Structure copied to clipboard (Benzene)
2022-12-09_15h44_56

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 107.0.5304.108 (Official Build) (64-bit)

Ketcher version
[2.6.4]
Additional info
If you select a different save format and then select v2000 again, then the coordinates disappear
https://user-images.githubusercontent.com/62464241/206707228-028782ac-4af1-4bb3-95a4-4bda2c7d6997.mp4
@Zhirnoff Zhirnoff added the bug label Dec 9, 2022
@Zhirnoff Zhirnoff added this to the Release 2.8.0 milestone Dec 9, 2022
@porcelain11 porcelain11 linked a pull request Dec 19, 2022 that will close this issue
#1902 Save hotkey CTRL+S: An atom or structure copied to the clipboard is saved with coordinates #1956
Merged
porcelain11 added a commit that referenced this issue Dec 20, 2022
@porcelain11
#1902 Add type for saver
7c5c028
porcelain11 added a commit that referenced this issue Dec 20, 2022
@porcelain11
#1902 Small refactoring - remove duplicate code
d3dd468
porcelain11 added a commit that referenced this issue Dec 29, 2022
@porcelain11
#1902 Create separate function to prevent not rendered structure from…
e363b3b 
… saving
porcelain11 added a commit that referenced this issue Dec 29, 2022
@porcelain11
#1902 Remove excess comment
2651c40
Nitvex pushed a commit that referenced this issue Jan 10, 2023
@porcelain11
#1902 Save hotkey CTRL+S: An atom or structure copied to the clipboar…
cc5a0ec 
…d is saved with coordinates (#1956)

* Refactor savebutton module to get rid of onSave error, update keyHandle to remove not rendered structure from one to be saved

* #1902 Add type for saver

* #1902 Small refactoring - remove duplicate code

* #1902 Create separate function to prevent not rendered structure from saving

* #1902 Remove excess comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@porcelain11 porcelain11

Labels
None yet
Projects
None yet
Milestone
Release Candidate 2.8.0-rc.1
3 participants
@Zhirnoff @KonstantinEpam23 @porcelain11