Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If switch to View Only Mode with Fragment Selection you cannot change or select another selection mode #5581

Closed
Zhirnoff opened this issue Sep 25, 2024 · 2 comments · Fixed by #5736 or #5756
Closed

If switch to View Only Mode with Fragment Selection you cannot change or select another selection mode #5581

Zhirnoff opened this issue Sep 25, 2024 · 2 comments · Fixed by #5736 or #5756
Assignees
@daniil-sloboda
Labels
MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: Medium
Milestone
Ketcher 2.26.0-rc.2

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Sep 25, 2024 •
edited
Loading

Steps to Reproduce

  1. Open Ketcher in normal mode.
  2. Use the Selection Tool and choose the "Fragment selection".
  3. Switch to "View Only" mode. ketcher.editor.options({ viewOnlyMode: true })

Actual behavior
In "View Only" mode, the "Fragment selection" option becomes unusable, and it's impossible to switch to other selection modes.
Additionally, if "Lasso" selection was chosen before switching to "View Only," it behaves like "Rectangle" selection in that mode.

Expected behavior
The user should be able to continue selecting fragments or switch between different selection modes, or all selection options should be blocked except Rectangle selection.
Proposed Solution: Block all selection modes except "Rectangle" and automatically switch to "Rectangle" selection when transitioning into "View Only" mode.
Screenshots

2024-09-25_11h49_42.mp4
2024-09-25_11h50_54.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.25.0-rc.4]
Indigo version
[Version 1.24.0-rc.3]
Bug found during testing: #4965
@Zhirnoff Zhirnoff added bug Priority: Medium MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Sep 25, 2024
@Zhirnoff Zhirnoff changed the title If switch to to View Only Mode with Fragment Selection you cannot change or select another selection mode If switch to View Only Mode with Fragment Selection you cannot change or select another selection mode Sep 25, 2024
daniil-sloboda added a commit that referenced this issue Oct 14, 2024
@daniil-sloboda
#5581 - fixed view only toggle fragment issue and multitail arrows un…
8c810a3 
…do\redo not saving coordinates
daniil-sloboda added a commit that referenced this issue Oct 14, 2024
@daniil-sloboda
#5581 - fixed tests
ec3d815
@Zhirnoff
Copy link
Collaborator Author

Pre-tested on Nightly. Bug fixed.

2024-10-14_13h26_41.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.1]
Indigo version
[Version 1.25.0-rc.1]

@rrodionov91 rrodionov91 linked a pull request Oct 14, 2024 that will close this issue
Backmerge: #5581 - fixed view only toggle fragment issue and multitail arrows undo\redo not saving coordinates #5736
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Oct 14, 2024
@daniil-sloboda
Backmerge: #5581 - fixed view only toggle fragment issue and multitai…
f9c4df6 
…l arrows undo\redo not saving coordinates (#5736)
rrodionov91 pushed a commit that referenced this issue Oct 14, 2024
@daniil-sloboda @rrodionov91
Backmerge: #5581 - fixed view only toggle fragment issue and multitai…
ad3067b 
…l arrows undo\redo not saving coordinates (#5736)

(cherry picked from commit f9c4df6)
@rrodionov91 rrodionov91 linked a pull request Oct 14, 2024 that will close this issue
#5097 - Selection frame is displayed improperly for overlapped images #5756
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Oct 14, 2024
@rrodionov91 @daniil-sloboda
#5097 - Selection frame is displayed improperly for overlapped images (…
7a99537 
…#5756)

* #5097 - Selection frame is displayed improperly for overlapped images (#5647)

* #5097 - гpdated selection frame display for images and simple objects
* #5097 - updated tests
* #5097 - updated width of stroke to pass tests

(cherry picked from commit f49f357)

* Backmerge: #5581 - fixed view only toggle fragment issue and multitail arrows undo\redo not saving coordinates (#5736)

(cherry picked from commit f9c4df6)

---------

Co-authored-by: Daniil Sloboda <[email protected]>
@Zhirnoff
Copy link
Collaborator Author

Tested. Bug fixed.

2024-10-15_15h32_26.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.2]
Indigo version
[Version 1.25.0-rc.2]

AlinaLysenko pushed a commit that referenced this issue Oct 16, 2024
@daniil-sloboda @AlinaLysenko
Backmerge: #5581 - fixed view only toggle fragment issue and multitai…
95787e8 
…l arrows undo\redo not saving coordinates (#5736)
Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@daniil-sloboda @Guch1g0v
Backmerge: #5581 - fixed view only toggle fragment issue and multitai…
deca6e6 
…l arrows undo\redo not saving coordinates (#5736)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniil-sloboda daniil-sloboda

Labels
MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: Medium
Projects
None yet
Milestone
Ketcher 2.26.0-rc.2
3 participants
@Zhirnoff @yauhen-karmyzau @daniil-sloboda