Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection frame is displayed improperly for overlapped images #5097

Closed
ivanmaslow opened this issue Jul 12, 2024 · 2 comments · Fixed by #5647 or #5756
Closed

Selection frame is displayed improperly for overlapped images #5097

ivanmaslow opened this issue Jul 12, 2024 · 2 comments · Fixed by #5647 or #5756
Assignees
@daniil-sloboda
Labels
Images Images support MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: High
Milestone
Ketcher 2.26.0-rc.2

Comments

@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Jul 12, 2024 •
edited
Loading

Steps to Reproduce

  1. Click on "Add Image"
  2. Select the image and add the first image to the canvas
  3. Click on "Add Image" again and add the second image to canvas to overlap the first image
  4. Select the second image

Actual behavior
The second image is on the top layer, but only part of the selection frame (or mouse over frame) is displayed
image
image

Expected behavior
The second image is on the top layer and the selection frame (or mouse over frame) is fully displayed

Desktop:

  • OS: Windows 11 Enterprise
  • Browser: Chrome 126.0.6478.127 (Official Build) (64-bit)

Ketcher version: Nightly 4902 [Version 2.23.0-rc.1] Build at 2024-07-12; 10:06:35.

Additional Context:
@ivanmaslow ivanmaslow added bug Images Images support MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Jul 12, 2024
@ivanmaslow ivanmaslow mentioned this issue Jul 12, 2024
Closed
@ivanmaslow ivanmaslow changed the title [Preview] Selection frame is displayed not proper for overlapped images Preview: Selection frame is displayed not proper for overlapped images Jul 16, 2024
@ivanmaslow
Copy link
Collaborator Author

ivanmaslow commented Jul 16, 2024 •
edited
Loading

Discussed with DM - no plans to fix in 2.24.0-rc.1, added to Refined Backlog, try to fix it in the next releases

@vanoprenko vanoprenko changed the title Preview: Selection frame is displayed not proper for overlapped images Preview: Selection frame is displayed improperly for overlapped images Aug 13, 2024
@ivanmaslow ivanmaslow changed the title Preview: Selection frame is displayed improperly for overlapped images Selection frame is displayed improperly for overlapped images Aug 14, 2024
@ivanmaslow ivanmaslow added this to the Backlog milestone Sep 3, 2024
@daniil-sloboda daniil-sloboda self-assigned this Oct 7, 2024
daniil-sloboda added a commit that referenced this issue Oct 7, 2024
@daniil-sloboda
#5097 - Updated selection frame display for images and simple objects
cb1edb8
@daniil-sloboda daniil-sloboda linked a pull request Oct 7, 2024 that will close this issue
Backmerge: #5097 - Selection frame is displayed improperly for overlapped images #5647
Merged
9 tasks
daniil-sloboda added a commit that referenced this issue Oct 8, 2024
@daniil-sloboda
#5097 - updated tests
57aa0c1
daniil-sloboda added a commit that referenced this issue Oct 9, 2024
@daniil-sloboda
#5097 - updated width of stroke to pass tests
b3953bb
daniil-sloboda added a commit that referenced this issue Oct 10, 2024
@daniil-sloboda
#5097 - updated tests
d76006f
rrodionov91 pushed a commit that referenced this issue Oct 11, 2024
@daniil-sloboda
#5097 - Selection frame is displayed improperly for overlapped images (…
f49f357 
…#5647)

* #5097 - гpdated selection frame display for images and simple objects
* #5097 - updated tests
* #5097 - updated width of stroke to pass tests
rrodionov91 pushed a commit that referenced this issue Oct 13, 2024
@daniil-sloboda @rrodionov91
#5097 - Selection frame is displayed improperly for overlapped images (…
fe11273 
…#5647)

* #5097 - гpdated selection frame display for images and simple objects
* #5097 - updated tests
* #5097 - updated width of stroke to pass tests
rrodionov91 pushed a commit that referenced this issue Oct 14, 2024
@daniil-sloboda @rrodionov91
#5097 - Selection frame is displayed improperly for overlapped images (…
1915519 
…#5647)

* #5097 - гpdated selection frame display for images and simple objects
* #5097 - updated tests
* #5097 - updated width of stroke to pass tests

(cherry picked from commit f49f357)
@rrodionov91 rrodionov91 linked a pull request Oct 14, 2024 that will close this issue
#5097 - Selection frame is displayed improperly for overlapped images #5756
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Oct 14, 2024
@rrodionov91 @daniil-sloboda
#5097 - Selection frame is displayed improperly for overlapped images (…
7a99537 
…#5756)

* #5097 - Selection frame is displayed improperly for overlapped images (#5647)

* #5097 - гpdated selection frame display for images and simple objects
* #5097 - updated tests
* #5097 - updated width of stroke to pass tests

(cherry picked from commit f49f357)

* Backmerge: #5581 - fixed view only toggle fragment issue and multitail arrows undo\redo not saving coordinates (#5736)

(cherry picked from commit f9c4df6)

---------

Co-authored-by: Daniil Sloboda <[email protected]>
@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Oct 15, 2024 •
edited
Loading

Verified.
image

  • Ketcher Version 2.26.0-rc.2 Build at 2024-10-14; 19:59:03
  • Indigo Toolkit Version 1.25.0-rc.2.0-g867ae250b-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.101 (Official Build) (64-bit)
  • Win10

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@daniil-sloboda @Guch1g0v
#5097 - Selection frame is displayed improperly for overlapped images (…
fa029a9 
…#5647)

* #5097 - гpdated selection frame display for images and simple objects
* #5097 - updated tests
* #5097 - updated width of stroke to pass tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniil-sloboda daniil-sloboda

Labels
Images Images support MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: High
Projects
None yet
Milestone
Ketcher 2.26.0-rc.2
4 participants
@AlexeyGirin @ivanmaslow @yauhen-karmyzau @daniil-sloboda