Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of ambiguous monomers in sequence view #4556

Closed
olganaz opened this issue Apr 30, 2024 · 2 comments · Fixed by #5378
Closed

Support of ambiguous monomers in sequence view #4556

olganaz opened this issue Apr 30, 2024 · 2 comments · Fixed by #5378
Assignees
@rrodionov91
Labels
Macromolecules Requirements Done Test Cases Written Test cases has been written for that issue variant_monomers
Milestone
Ketcher 2.25.0-rc.1

Comments

@olganaz
Copy link
Collaborator

olganaz commented Apr 30, 2024 •
edited by ljubica-milovic
Loading

Background
Support for ambiguous monomers in sequence mode (X, N, etc.)

Requirements

  1. Ambiguous monomers with a letter symbol (R, Y, M, K, S, W, H, B, V, D and N for RNA/DNA, and B, J, Z and X for peptides; see: #2015) should be represented as those symbols in sequence mode.
  2. Other ambiguous monomers should be displayed as % in sequence mode.
  3. Previews for hovering over the monomers in sequence mode are addressed in the related issue: #4555.

UX
image
@rrodionov91 rrodionov91 added this to the Ketcher 2.25.0-rc.1 milestone Jul 22, 2024
@AlexeyGirin AlexeyGirin added the Test Cases Written Test cases has been written for that issue label Aug 13, 2024
@AlexeyGirin
Copy link
Collaborator

Test cases added

@ljubica-milovic ljubica-milovic changed the title Macro: Support of variant monomers in sequence view Macro: Support of ambiguous monomers in sequence view Aug 26, 2024
@rrodionov91 rrodionov91 changed the title Macro: Support of ambiguous monomers in sequence view Support of ambiguous monomers in sequence view Aug 28, 2024
rrodionov91 added a commit that referenced this issue Aug 28, 2024
@rrodionov91
#4556 - Support of ambiguous monomers in sequence view
0d098cf
@rrodionov91 rrodionov91 linked a pull request Aug 28, 2024 that will close this issue
#4556 - Support of ambiguous monomers in sequence view #5378
Merged
9 tasks
svvald pushed a commit that referenced this issue Aug 28, 2024
@rrodionov91
#4556 - Support of ambiguous monomers in sequence view (#5378)
c2227cf
This was referenced Sep 4, 2024
Closed
Closed
Closed
Open
@AlexeyGirin
Copy link
Collaborator

Verified.
image

Versions

  • Ketcher Version 2.25.0-rc.1 Build at 2024-09-03; 15:31:03
  • Indigo Toolkit Version 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0
  • Chrome Version 128.0.6613.114 (Official Build) (64-bit)
  • Win10

This was referenced Sep 24, 2024
Open
Closed
@AlinaLysenko AlinaLysenko mentioned this issue Sep 27, 2024
Closed
This was referenced Oct 14, 2024
Open
Open
@AlexeyGirin AlexeyGirin mentioned this issue Oct 14, 2024
Open
Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
#4556 - Support of ambiguous monomers in sequence view (#5378)
6a602db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
Macromolecules Requirements Done Test Cases Written Test cases has been written for that issue variant_monomers
Projects
None yet
Milestone
Ketcher 2.25.0-rc.1
Development

Successfully merging a pull request may close this issue.

#4556 - Support of ambiguous monomers in sequence view epam/ketcher
5 participants
@rrodionov91 @AlexeyGirin @Andrey-Antonov @olganaz @ljubica-milovic