Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sqlite tests on mac #9408

Closed
wants to merge 3 commits into from
Closed

Disable sqlite tests on mac #9408

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed950a3
Disable sqlite tests on mac
GregoryTravis Mar 13, 2024
f526ce3
move to Main
GregoryTravis Mar 14, 2024
a440f35
import
GregoryTravis Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/Table_Tests/src/Database/SQLite_Spec.enso
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from Standard.Base import all
import Standard.Base.Runtime.Ref.Ref
from Standard.Base.Runtime import assert
import Standard.Base.System.Platform.OS
import Standard.Base.Errors.File_Error.File_Error
import Standard.Base.Errors.Illegal_Argument.Illegal_Argument

Expand Down Expand Up @@ -454,5 +455,6 @@ add_specs suite_builder =

main filter=Nothing =
suite = Test.build suite_builder->
add_specs suite_builder
if Platform.os != OS.Mac_OS then
add_specs suite_builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this accomplishes what you want to accomplish. This will only skip SQLite tests when you run them as enso --run test/Table_Tests/src/Database/SQLite_Spec.enso and not if you run them as enso --run test/Table_Tests. I believe that you rather want:

diff --git a/test/Table_Tests/src/Database/Main.enso b/test/Table_Tests/src/Database/Main.enso
index fc8f6f56f..28dad6384 100644
--- a/test/Table_Tests/src/Database/Main.enso
+++ b/test/Table_Tests/src/Database/Main.enso
@@ -9,7 +9,8 @@ import project.Database.Redshift_Spec
 
 add_specs suite_builder =
     Codegen_Spec.add_specs suite_builder
-    SQLite_Spec.add_specs suite_builder
+    if Platform.os != OS.Mac_OS then
+        SQLite_Spec.add_specs suite_builder
     Postgres_Spec.add_specs suite_builder
     Redshift_Spec.add_specs suite_builder

By the way, you can mark a whole group as pending.

suite.run_with_filter filter
Loading