-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable sqlite tests on mac #9408
Conversation
add_specs suite_builder | ||
if Platform.os != OS.Mac_OS then | ||
add_specs suite_builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this accomplishes what you want to accomplish. This will only skip SQLite tests when you run them as enso --run test/Table_Tests/src/Database/SQLite_Spec.enso
and not if you run them as enso --run test/Table_Tests
. I believe that you rather want:
diff --git a/test/Table_Tests/src/Database/Main.enso b/test/Table_Tests/src/Database/Main.enso
index fc8f6f56f..28dad6384 100644
--- a/test/Table_Tests/src/Database/Main.enso
+++ b/test/Table_Tests/src/Database/Main.enso
@@ -9,7 +9,8 @@ import project.Database.Redshift_Spec
add_specs suite_builder =
Codegen_Spec.add_specs suite_builder
- SQLite_Spec.add_specs suite_builder
+ if Platform.os != OS.Mac_OS then
+ SQLite_Spec.add_specs suite_builder
Postgres_Spec.add_specs suite_builder
Redshift_Spec.add_specs suite_builder
By the way, you can mark a whole group as pending
.
If #9438 works, this won't be necessary. |
Looks like #9438 worked, so closing this. |
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.