Show status mesage if a visualisation is closed due to engine error. #6937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a status messages when a visualisation is closed through an engine error.
MichaelMauderer
added
the
CI: No changelog needed
MichaelMauderer
requested review from
wdanilo,
farmaazon,
kazcw and
mwu-tow
as code owners
farmaazon
approved these changes
Jun 5, 2023
Comment on lines
231
to
233
| error!("Visualization {} failed to attach: {error}.", visualization.id); | ||
| model.handle_controller_failure(&failure_endpoint, visualization.expression_id); | ||
| let message = | ||
| format!("Failed to open visualization because of an error: {error}."); |
There was a problem hiding this comment.
The {error} messages should already have a dot at the end.
| @@ -245,11 +255,17 @@ impl Visualization { | |||
| "Visualization {} failed to be modified: {error}. Will hide it in GUI.", | |||
| desired.id | |||
| ); | |||
| let message = | |||
| format!("Failed to modify visualization because of an error: {error}."); | |||
There was a problem hiding this comment.
Suggested change
| format!("Failed to modify visualization because of an error: {error}."); | |
| format!("Failed to modify visualization because of an error: {error}"); |
QA: 🟢 |
MichaelMauderer
added
the
CI: Ready to merge
…n_visualisation_closes_because_of_engine_error # Conflicts: # app/gui/src/presenter/graph/visualization.rs
mergify
bot
deleted the
wip/MichaelMauderer/Add_error_message_when_visualisation_closes_because_of_engine_error
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Peek.2023-06-02.15-16.mp4
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.