-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node preview occasionally doesn't work - closes before showing results #6724
Comments
Please add the information if you are using the local installation or the cloud @xvcgreg |
Hmm, I've suspected we close visualization due to receiving some error on visualization/attach... But in that case, the error log should be printed. |
It may be caused by not-quite-working |
Michael Mauderer reports a new STANDUP for yesterday (2023-05-30): Progress: Started investigating the closing preview. Difficult to reproduce at first, but found a way to reproduce the issue quite reliably with large files. Unfortunately, after that, I ran into an issue with logging not working in the cloud mode in the IDE. It should be finished by 2023-06-01. Next Day: Next day I will be working on the #6724 task. Figure out broken logging. |
Due to #6899 I cannot debug this properly in the cloud environment. I can, however, reproduce the same behaviour locally for large enough data sets (200MB as a table vis). The observed behaviour in this scenario is caused by a timeout on the engine side: While we can (and should) increase the timeout, but this will only alleviate but not solve the problem. Ideally, the IDE should show the correct error message to the user, to inform them what is happening (i.e., the visualization is closed due to a timeout). So, I propose:
Do you agree with this as a solution to this issue, or are there any other suggestions, or comments? @farmaazon @xvcgreg @sylwiabr @wdanilo |
I believe that the solution proposed by you, Michael, is correct. Unless someone else has a better idea / adjustments, let's do it. |
Try network throttling on chrome with |
The second point brings a bit of logic (and design) here. I believe we could do it by
For now, I think 2 is nicer, as we avoid "someone just hid my visualization!" effect: the box is still there, it just has an error message. Anyway, let's do the point 1 as a separate fix now. I have also a third idea: |
I was just thinking of using the current mechanism for showing an error at the top of the IDE. I assume this is the mechanism that will get extended in #5201 ?
I don't think this will solve this problem. In this case, the computation of the visualization just takes too long on the engine side and is aborted there. Every additional attempt initiated from the IDE, in the same way, will most likely take just as long. |
Yes, however, there is one important detail here. IDE should not hide visualization if it waits long for data. The data arrival is in a separate message and it does not have a timeout. But we hide visualization if the attaching fails. Now, there are two reasons it could fail:
|
Yes, I added a point there for various failures (including visualization attaching). |
I don't think it does. When playing around with throttled bandwidth speed, the visualizations stayed in the loading state until I got data or bored. The observed error clearly originates on the engine side and is actively propagated. |
Michael Mauderer reports a new STANDUP for the provided date (2023-05-30): Progress: Was unable to quickly figure out the logging problem, filed a new issue instead of solving it. But I also managed to reproduce the bug locally and started discussion about the best course of action. It should be finished by 2023-06-01. Next Day: Next day I will be working on the #6724 task. Implement solution from discussion. |
Michael Mauderer reports a new 🔴 DELAY for today (2023-06-01): Summary: There is 2 days delay in implementation of the Node preview occasionally doesn't work - closes before showing results (#6724) task. Delay Cause: Adding a notification from the place where we handle the visualization attachment is not trivial, as there is no generic mechanism, for this yet. This will require some understanding and refactoring in the IDE controller, maybe implementing a proper mechanism for any component to generate user-facing error messages. |
Michael Mauderer reports a new STANDUP for today (2023-06-01): Progress: Started implementing the proposed solution for the bug. Noticed that generating a user-facing error is not trivial presently. It should be finished by 2023-06-03. Next Day: Next day I will be working on the #6724 task. Implement mechanism to generate user-facing error messages and use it to show a sensible error on visualisation attachment failure. |
I'm starting to get lost in this thread so excuse me if the remark sounds banal but I believe engine has no timeout when it comes computing the visualization data. It might take a while but it should not timeout. Do you have an example where it shows that it aborted the computation?
Response for Attach visualization request should be near instant, agreed. If it is too long and because of engine, that's a bug. |
Please look at an engine's log line posted in #6724 (comment) Here we see there is some timeout inside the engine (as this is an engine log), and it's related to attaching process (so perhaps it's not timeout for waiting for data, only for attaching result). @MichaelMauderer do you have a full engine log for that case? |
@farmaazon Thanks. The problem with those warnings is that they may be spurious and caused by successive file editions #5985 is one example. |
@hubertp Let me know if there is anything else I can provide. Full Console output
|
@hubertp Could you point me to the correct timeout that needs to be adjusted for this? I was unable to identify the right place for certain. I think this might be it, but it looks like this might affect much more code than intended: enso/engine/language-server/src/main/scala/org/enso/languageserver/boot/TimingsConfig.scala Line 42 in cfb2f29
|
This comment was marked as duplicate.
This comment was marked as duplicate.
Michael Mauderer reports a new 🔴 BLOCKER for today (2023-06-02): Summary: The Node preview occasionally doesn't work - closes before showing results (#6724) task is blocked by the #6899 task. Actual blocker size unknown. Blocker prevents debugging the IDE when using a cloud project. |
Michael Mauderer reports a new 🔴 DELAY for today (2023-06-02): Summary: There is 4 days delay in implementation of the Node preview occasionally doesn't work - closes before showing results (#6724) task. Disregard last delay message. That was a copy/paste error. The overall delay expected to be 6 days. 2 days weekend, 2 days to fix the bug, 2 days to solve the blocker. Delay Cause: The bugfix that was fixing a bug did not fix the described behaviour in the cloud, only a very similar behaviour locally. Debugging the cloud is blocked by #6899 |
Michael Mauderer reports a new STANDUP for today (2023-06-02): Progress: Implemented status messages for visualisations that are closed due to an engine error. Tested this in the original issue described in the cloud environment and noticed that it does not affect the behavior. More bug hunting is required, but that will require #6899 to be fixed first. It should be finished by 2023-06-09. Next Day: Next day I will be working on the #6724 task. Work on investigating #6899 |
Yes, that's the default. |
Michael Mauderer reports a new STANDUP for yesterday (2023-06-05): Progress: Investigated why logging is not appearing. It appears that some logging is swallowed by an unclosed logging group. But also, the IDE used for cloud project is loaded from an external server and never using the locally compiled one, thus not picking up any changes. It should be finished by 2023-06-09. Next Day: Next day I will be working on the #6724 task. Work on avoiding #6899 |
@farmaazon @MichaelMauderer Should this ticket still be open? I've added some significant improvements on the LS side which should have remedied the problem. |
Discord username
No response
What type of issue is this?
Intermittent – Occurring irregularly
Is this issue blocking you from using Enso?
Is this a regression?
What issue are you facing?
While working with a cloud project, when pressing spacebar on
column_names
node preview takes very long to load and eventually preview window disappears without showing the results.2305171212_shareX.mp4
Expected behaviour
Preview is shown promptly and stays on until turned off by a user.
How we can reproduce it?
No response
Screenshots or screencasts
No response
Enso Version
2023.5.17 nightly
Browser or standalone distribution
Standalone distribution
Browser Version or standalone distribution
standalone
Operating System
Windows
Operating System Version
Win11pro 22H2 22621.1555
Hardware you are using
12th Gen Intel(R) Core(TM) i9-12900HK / RTX3060 Laptop / Nvidia Drivers 531.68
The text was updated successfully, but these errors were encountered: