-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CB discarding changes if pressed Ctrl + Enter too quickly #6875
Conversation
QA report: 🔴
cb-double-confirm.mp4
cb-type-select.mp4 |
|
@Frizi fix landed, please check out. |
QA Status: 🍌Ctrl+enter works correctly, It will always accept currently written input. The issues mentioned above are now fixed. There is still an issue related to input lag when simply using cb-quick-type.mp4 |
Pull Request Description
Now, quick typing in component browser and pressing "enter" should not cut off the last part typed. Fixes #6733
ugi-bugi-2023-05-29_15.00.35.mp4
On this occasion, also fixed "go-to-dashboard" button and "Unsupported engine version" being over the full-screen visualization. Fixes #6722
Important Notes
I did a significant refactoring of Project View:
frp::extend
block was split into multipleinit
methods.The code was mostly moved around, but the check is advised anyway, as there were small changes here and there.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.