Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong entry selected in Component Browser if Enter is pressed too fast #6913

Closed
radeusgd opened this issue May 31, 2023 · 2 comments
Closed
Labels
--bug Type: bug s-duplicate Status: a duplicate issue

Comments

@radeusgd
Copy link
Member

See the following video:

Enso_QkfHXl8hSF.mp4

On the first try I typed first and pressed Enter so fast that the keystrokes of first did not even get a chance to render... So it inserted the default node: to_table - totally ignoring what I typed.

On second try I was slow and the CB actually did manage to select the first and then it inserted correctly the node first. Yay.

On third try I was just right - you can see that my keystrokes did make first appear in the new-node-creation-field - so they were registered. But the searched did not yet switch to the correct entry before the Enter event was processed. And so even though the Node displayed first, after clicking Enter, to_table was inserted again.

It seems that the "Enter" action is processed too soon. Some sort of event queueing should happen to ensure that all necessary processing of keystrokes that have been inputted is finished, before processing of Enter, dependant on these, starts.

Otherwise, maybe the "Enter" keystroke should simply not register if other events are being processed (giving the user a chance to wait until all 'settles', the CB displays the correct entry etc. and to try pressing Enter again afterwards).

Regardless of the solution, I think the current behaviour is problematic. As a fast-typing user I'm punished - I have to explicitly wait until the CB loads and switches to the right option (which takes 2s+ after warmup and even worse on first try - that is ages for text editing usecases where one can do 80 words per minute - i.e. typing one full word (= method name) usually takes around 1s).

@radeusgd
Copy link
Member Author

I thought this was meant to be fixed by #6812 but I'm running a build containing this commit and the behaviour is as shown on the video.

@farmaazon
Copy link
Contributor

This should be actually fixed by #6875 which is not merged yet, so probably you haven't had this fix.

It's a duplicate of #6733 or #6908 or both.

@farmaazon farmaazon added s-duplicate Status: a duplicate issue and removed triage labels Jun 1, 2023
@farmaazon farmaazon closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2023
@github-project-automation github-project-automation bot moved this from ❓New to 🟢 Accepted in Issues Board Jun 1, 2023
@sylwiabr sylwiabr removed this from Issues Board Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug s-duplicate Status: a duplicate issue
Projects
None yet
Development

No branches or pull requests

2 participants