Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Assets Tree flat #12134

Merged
merged 35 commits into from
Feb 28, 2025
Merged

Make the Assets Tree flat #12134

merged 35 commits into from
Feb 28, 2025

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Jan 24, 2025

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

Copy link
Contributor

mergify bot commented Jan 24, 2025

⚠️ The sha of the head commit of this PR conflicts with #12115. Mergify cannot evaluate rules on this PR. ⚠️

Copy link

github-actions bot commented Jan 24, 2025

🧪 Storybook is successfully deployed!

📊 Dashboard:

@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/flatten-assets-tree branch from 42690cc to c66733a Compare January 28, 2025 08:14
@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/flatten-assets-tree branch from b5b7283 to 5d82374 Compare February 19, 2025 09:58
@MrFlashAccount MrFlashAccount self-assigned this Feb 19, 2025
@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/flatten-assets-tree branch from f9d0efa to f51c570 Compare February 24, 2025 10:17
@MrFlashAccount MrFlashAccount added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard labels Feb 24, 2025
@MrFlashAccount MrFlashAccount marked this pull request as ready for review February 24, 2025 12:17
@PabloBuchu
Copy link
Contributor

PabloBuchu commented Feb 24, 2025

  1. Context menu is not working in subdirectory
  2. Drag n drop upload always put file in root (either user or team space)
  3. I can't drag n drop asset on directory when I am not in root.
  4. Drag n drop of datalinks is not working
    5. Please add .. indicating parent directory

@somebody1234
Copy link
Contributor

1, 2, 3 seem already fixed by sergei

@somebody1234
Copy link
Contributor

Drag n drop upload always put file in root

oops this was broken, easy fix though

@PabloBuchu PabloBuchu added the CI: Ready to merge This PR is eligible for automatic merge label Feb 27, 2025
@mergify mergify bot merged commit 0b061a4 into develop Feb 28, 2025
59 of 61 checks passed
@mergify mergify bot deleted the wip/sergeigarin/flatten-assets-tree branch February 28, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants