Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake Dialect pt. 5 #10528

Merged
merged 16 commits into from
Jul 16, 2024
Merged

Snowflake Dialect pt. 5 #10528

merged 16 commits into from
Jul 16, 2024

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jul 11, 2024

Pull Request Description

  • Related to Snowflake Dialect #9486
  • Batching of expression tests
  • Fixing arithmetic by simplifying % and / operations
  • Trying to share some more tables, sometimes improving performance sometimes not really
  • Adding sorting and other fixes to tests to make them pass: Missing_Values_Spec, Filter_Spec, Map_Spec
  • Fixing warnings related to materialization of Decimal->Integer, thus fixing Join_Spec.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 11, 2024
@radeusgd radeusgd self-assigned this Jul 11, 2024
@radeusgd radeusgd changed the base branch from develop to wip/radeusgd/snowflake-dialect-4 July 11, 2024 13:53
Base automatically changed from wip/radeusgd/snowflake-dialect-4 to develop July 11, 2024 20:14
@radeusgd radeusgd force-pushed the wip/radeusgd/snowflake-dialect-5 branch from 2f5643a to 7e9b935 Compare July 11, 2024 20:16
@radeusgd radeusgd marked this pull request as ready for review July 12, 2024 06:06
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Jul 15, 2024
@mergify mergify bot merged commit a30b0c6 into develop Jul 16, 2024
37 checks passed
@mergify mergify bot deleted the wip/radeusgd/snowflake-dialect-5 branch July 16, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants