Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in the workflow are making IDE sluggish #6674

Closed
2 tasks
sylwiabr opened this issue May 12, 2023 · 8 comments · Fixed by #6954
Closed
2 tasks

Errors in the workflow are making IDE sluggish #6674

sylwiabr opened this issue May 12, 2023 · 8 comments · Fixed by #6954
Assignees
Labels

Comments

@sylwiabr
Copy link
Member

sylwiabr commented May 12, 2023

Discord username

No response

What type of issue is this?

Permanent – Occurring repeatably

Is this issue blocking you from using Enso?

  • Yes, I can't use Enso because of this issue.

Is this a regression?

  • Yes, previous version of Enso did not have this issue.

What issue are you facing?

When I am working with bigger project and break it at the beginning first IDE is freezing for the time when errors are getting populated. Having many errors is also slowing down IDE when trying to work with it on weaker hardware (editing nodes, zooming, panning are having delays). Breaking first node on Restaurants example available in our templates is already freezing my IDE on M2 MacOS.

Expected behaviour

Errors on nodes should not affect IDE performance.

How we can reproduce it?

No response

Screenshots or screencasts

No response

Enso Version

nightly 12.05.2023

Browser or standalone distribution

Standalone distribution

Browser Version or standalone distribution

standalone

Operating System

Windows

Operating System Version

No response

Hardware you are using

No response

@hubertp
Copy link
Collaborator

hubertp commented May 15, 2023

That seems very much like a duplicate of #6639

@Akirathan Akirathan added --low-performance and removed --bug Type: bug labels May 15, 2023
@Akirathan
Copy link
Member

This is a twofold issue:

  • The first one is that IDE does have an unnecessarily long rendering of erroneous state.
  • The second one is that the protocol between the IDE and Language server is not really ideal for these kinds of things - for rebuilding of a huge count of nodes.

@Akirathan Akirathan added the -gui label May 15, 2023
@Akirathan Akirathan added p-low Low priority and removed triage labels May 15, 2023
@farmaazon farmaazon added this to the Design Partners milestone May 19, 2023
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board May 19, 2023
@kazcw kazcw moved this from 📤 Backlog to ⚙️ Design in Issues Board Jun 6, 2023
@enso-bot
Copy link

enso-bot bot commented Jun 6, 2023

Keziah Wesley reports a new STANDUP for the last Friday (2023-06-02):

Progress: Found an easy way to get a significant improvement. It should be finished by 2023-06-08.

Next Day: Next day I will be working on the #6674 task. Looking further into root causes (view invalidation)

@enso-bot
Copy link

enso-bot bot commented Jun 6, 2023

Keziah Wesley reports a new STANDUP for today (2023-06-05):

Progress: While profiling, found that when a few visualizations are open they can quickly become the biggest time cost. Found this is partly due to inefficient handling of updates. It should be finished by 2023-06-08.

Next Day: Next day I will be working on the #6674 task. Implementing more efficient visualization updates.

@enso-bot
Copy link

enso-bot bot commented Jun 6, 2023

Keziah Wesley reports a new STANDUP for today (2023-06-06):

Progress: Improved responsiveness with visualizations open by eliminating message deserialization as a performance bottleneck. It should be finished by 2023-06-08.

Next Day: Next day I will be working on the #6674 task. Additional performance improvements for visualizations changes.

@kazcw kazcw linked a pull request Jun 8, 2023 that will close this issue
5 tasks
@enso-bot
Copy link

enso-bot bot commented Jun 9, 2023

Keziah Wesley reports a new STANDUP for yesterday (2023-06-07):

Progress: Working on some GUI bugs. Some work on fixing visualization-related slowness. It should be finished by 2023-06-08.

Next Day: Next day I will be working on the #6674 task. Finish current batch of bugs and performance improvements.

@kazcw kazcw moved this from ⚙️ Design to 🔧 Implementation in Issues Board Jun 9, 2023
mergify bot pushed a commit that referenced this issue Jun 14, 2023
Fixes performance problems observed when creating/resolving errors (#6674):

|before|after|
|---|---|
|![vokoscreenNG-2023-06-09_08-49-46.webm](https://github.com/enso-org/enso/assets/1047859/a0048b32-4906-41cd-8899-6e2543ef6942)|![vokoscreenNG-2023-06-09_08-50-54.webm](https://github.com/enso-org/enso/assets/1047859/fef81512-ad89-4418-ae10-d54de94d96ea)|

This also helps with #6637, although I haven't been able to reproduce the degree of slowness shown there so I can't confirm that this resolves that issue.

# Important Notes
- Disable visualizations until shown. [Faster startup, and all graph changes.]
- 6x faster message deserialization. [Saves 400ms when making a change with many visualizations open.]
- Fast edge recoloring. [Saves 100-150ms when disconnecting an edge in Orders.]
- Add a checked implementation of a `profiler` data structure, used instead of the fast `unsafe` version when `debug-assertions` are enabled.
@mergify mergify bot closed this as completed in #6954 Jun 14, 2023
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Jun 14, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Jun 16, 2023
@enso-bot
Copy link

enso-bot bot commented Jul 19, 2023

Keziah Wesley reports a new STANDUP for the provided date (2023-06-01):

Progress: Finished the #6544 PR; started profiling #6674. It should be finished by 2023-06-08.

@enso-bot
Copy link

enso-bot bot commented Jul 19, 2023

Keziah Wesley reports a new STANDUP for the provided date (2023-06-08):

Progress: Fixed issue with eager visualization attachment, and finished PR. It should be finished by 2023-06-08.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants