Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Table/Column operations' signatures to be checked #12138

Closed
radeusgd opened this issue Jan 24, 2025 · 4 comments · Fixed by #12283
Closed

Update Table/Column operations' signatures to be checked #12138

radeusgd opened this issue Jan 24, 2025 · 4 comments · Fixed by #12283
Assignees
Labels
-libs Libraries: New libraries to be implemented x-refactor Changes that should not be visible to the end-user

Comments

@radeusgd
Copy link
Member

Currently many of our Table/Column operations do not have checked signatures. We should update that - this will allow us to reap benefits from the type inference and will make us more prepared for testing intersection types in anger.

@radeusgd radeusgd added -libs Libraries: New libraries to be implemented x-refactor Changes that should not be visible to the end-user labels Jan 24, 2025
@radeusgd radeusgd self-assigned this Jan 24, 2025
radeusgd added a commit that referenced this issue Jan 24, 2025
@radeusgd radeusgd moved this from ❓New to 🔧 Implementation in Issues Board Jan 24, 2025
@radeusgd radeusgd moved this from 🔧 Implementation to 📤 Backlog in Issues Board Jan 24, 2025
@radeusgd radeusgd moved this from 📤 Backlog to 🔧 Implementation in Issues Board Feb 13, 2025
@enso-bot
Copy link

enso-bot bot commented Feb 17, 2025

Radosław Waśko reports a new STANDUP for the provided date (2025-02-13):

Progress: Reviewing Table/Column signatures. It should be finished by 2025-02-18.

Next Day: Next day I will be working on the same task. Continue.

@enso-bot
Copy link

enso-bot bot commented Feb 17, 2025

Radosław Waśko reports a new STANDUP for the provided date (2025-02-14):

Progress: Extending James's Linter tool to automate upgrading type signatures. It should be finished by 2025-02-18.

Next Day: Next day I will be working on the same task. Finish.

@enso-bot
Copy link

enso-bot bot commented Feb 18, 2025

Radosław Waśko reports a new STANDUP for yesterday (2025-02-17):

Progress: Finished reformatting files and signatures, now ensuring that tests are passing. PR is ready. In the meantime got back to checking benchmarks for the error handling PR. Got a few inconclusive results - scheduled one more run, manually comparing a few stdlib ones. It should be finished by 2025-02-18.

Next Day: Next day I will be working on the same task. Compare the new benchmarks, check CI issues and try moving forward with that PR. Then next tasks.

@radeusgd radeusgd moved this from 🔧 Implementation to 👁️ Code review in Issues Board Feb 18, 2025
@enso-bot
Copy link

enso-bot bot commented Feb 19, 2025

Radosław Waśko reports a new STANDUP for yesterday (2025-02-18):

Progress: Getting the refactor PR ready, work on upadting the linter PR. Error handling PR - updated to latest develop, applied API changes diff (had to fix line endings issue on Windows) and trying to inspect a suspicious benchmark, setting up IGV. It should be finished by 2025-02-19.

Next Day: Next day I will be working on the #12316 task. Investigate possible benchmark regression; finish the changes to Linter PR.

@mergify mergify bot closed this as completed in #12283 Feb 19, 2025
@mergify mergify bot closed this as completed in 59c82f3 Feb 19, 2025
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented x-refactor Changes that should not be visible to the end-user
Projects
Status: 🟢 Accepted
Development

Successfully merging a pull request may close this issue.

1 participant