Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key-pair authentication for Snowflake #12136

Closed
3 tasks done
radeusgd opened this issue Jan 24, 2025 · 5 comments · Fixed by #12247
Closed
3 tasks done

Key-pair authentication for Snowflake #12136

radeusgd opened this issue Jan 24, 2025 · 5 comments · Fixed by #12247
Assignees
Labels
-libs Libraries: New libraries to be implemented l-db-connector Libraries: database connectors x-new-feature Type: new feature request

Comments

@radeusgd
Copy link
Member

radeusgd commented Jan 24, 2025

Apart from the OAuth flow (#12011) we also want users to rely on key-pair authentication when connecting to Snowflake.

  • Allow Snowflake connection to take a private key file from disk to use when connecting.
  • Allow Snowflake connection to take an Enso_Secret that contains the private key.
  • Create a helper method that generates the key-pair and stores the private key as an Enso_Secret and the public key as an Enso_File next to it.
@radeusgd radeusgd added -libs Libraries: New libraries to be implemented l-db-connector Libraries: database connectors x-new-feature Type: new feature request labels Jan 24, 2025
@radeusgd radeusgd self-assigned this Jan 24, 2025
@radeusgd radeusgd moved this from ❓New to 📤 Backlog in Issues Board Jan 24, 2025
@radeusgd radeusgd moved this from 📤 Backlog to 🔧 Implementation in Issues Board Feb 5, 2025
@enso-bot
Copy link

enso-bot bot commented Feb 7, 2025

Radosław Waśko reports a new STANDUP for yesterday (2025-02-06):

Progress: Finished the error handling PR. Implemented basic key-pair auth for Snowflake. It should be finished by 2025-02-11.

Next Day: Next day I will be working on the same task. Implement key-pair generation for Snowflake auth.

@enso-bot
Copy link

enso-bot bot commented Feb 7, 2025

Radosław Waśko reports a new STANDUP for today (2025-02-07):

Progress: Implemented key pair generation, with visuallization helping how to finish the setup. Fixed passing private key to Snowflake JDBC. It should be finished by 2025-02-11.

Next Day: Next day I will be working on the same task. Fix using local private key with passkey. Add some testing.

@enso-bot
Copy link

enso-bot bot commented Feb 11, 2025

Radosław Waśko reports a new STANDUP for yesterday (2025-02-10):

Progress: Working on testing key-pair auth. Implemented test scenario for the Cloud key-pair flow. It should be finished by 2025-02-11.

Next Day: Next day I will be working on the same task. Add tests for local, Fix using local private key with passkey.

@radeusgd radeusgd moved this from 🔧 Implementation to 👁️ Code review in Issues Board Feb 11, 2025
@enso-bot
Copy link

enso-bot bot commented Feb 12, 2025

Radosław Waśko reports a new STANDUP for yesterday (2025-02-11):

Progress: Added tests for local key pair, generating a test key pair using Snowflake Java utils. Key generated using openssl seems to still not work if encrypted with passphrase. Tried upgrading to newer Snowflake JDBC but that didn't seem to help. After all added a better error message recommending to prefer the Cloud flow that is guaranteed compatible. Created some benchmarks for Table tests. It should be finished by 2025-02-11.

Next Day: Next day I will be working on the same task. Some more work on benchmarks, then next tasks.

@enso-bot
Copy link

enso-bot bot commented Feb 13, 2025

Radosław Waśko reports a new STANDUP for yesterday (2025-02-12):

Progress: Investigated an issue with failing tests on the key-pair auth PR. Found #12266 bug and implemented a workaround to try pass the tests. Added a few more benchmarks, and verified some assertions. Trying to add more data to the generated XML report. It should be finished by 2025-02-13.

Next Day: Next day I will be working on the #12138 task. Start next task.

@mergify mergify bot closed this as completed in #12247 Feb 13, 2025
@mergify mergify bot closed this as completed in 33a9ba9 Feb 13, 2025
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented l-db-connector Libraries: database connectors x-new-feature Type: new feature request
Projects
Status: 🟢 Accepted
Development

Successfully merging a pull request may close this issue.

1 participant