-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add devices Alert/Pump, UOMs #755
Conversation
ok, will check on HA |
@MichaelDvP What shall I do to test for ems-esp? |
@tp1de checkout this PR or dev from my repo, remove the comment marks emsdevices.cpp line 59/69, compile. |
@MichaelDvP I compiled. Translations of times are working (German). uom m³ does not work for api / ha. The other 2 are fine for English / German: { |
Not a charset issue, just the reference to the strings for cubicmeters and liters were missing. |
Yes works now. |
I just have seen that for sensor type counter the factor can't be 0.01. It might be used for gas consumption - my meter gives an impulse every 0.01 m3. I do not need it since I use a Raspberry Pi for this but it might be of general interest .... |
hmmmm |
This depends on browser, firefox accepts input 0,01, edge likes to round to step value of 0,1 on input, then you could edit inserting zeros.
Has anybody yet tested HA? Sensorconfig looks ok to me:
|
Thanks for info ... I never tested analog sensors within ioBroker. I have'nt had a look at the code for some months now. I will check. I am on the way to move to ha. |
I'm planning to test HA tonight |
@MichaelDvP #752 - the translations of UOM seem to work fine in HA, so I would say un-comment the lines at #59 and merge this PR |
@MichaelDvP if you want you can check latest ioBroker adapter version by installing from GH. UOM's should work now for Sensors as well. |
@proddy Ok, i've also changed the lot of |
Michael fixed it and I confirm it works in HA |
For #575 and #720 there are now extra devices without entitiies, check if you are ok with the icons.
I've changed some uoms to utf-8 characters (µA, m², m³), api/mqtt works ok for me, but check if HA accepts it.
Also for #752 i've added the possibe translation of times (seconds/minutes/hours), but commented out, please first check if it is ok with HA. (emsdevice.cpp, line 59)