Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor UI bugs with decimal values (adding / editing analog sensor dialog) #774

Closed
lmbd opened this issue Nov 27, 2022 · 6 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@lmbd
Copy link

lmbd commented Nov 27, 2022

Bug description
While playing around with the analog sensor dialog I've identified 2 minor UI bugs

  1. hint texts for start value and factor are misleading as they're stating that only integers are valid (which is not true)
  2. it's not possible to enter decimal values with an leading 0 after decimal point (only possible with a workaround - see recording)

Screenshots

Screen.Recording.2022-11-27.at.20.01.43.mov

Screenshot 2022-11-27 at 20 01 27

Device information
emsesp_settings (1).txt

@lmbd lmbd added the bug Something isn't working label Nov 27, 2022
@proddy
Copy link
Contributor

proddy commented Nov 27, 2022

very cool the video! As they say, a picture is a thousand words. We can update the hint text. The leading zero we need to fix. Both @MichaelDvP and myself have tried different techniques but it remains challenging.

Should the counter not be in whole integers?

@proddy proddy added this to the v3.5.0 milestone Nov 27, 2022
@MichaelDvP
Copy link
Contributor

We had this issue in: #755 (comment)
It depends on browser and the "step" setting of input field.

@lmbd
Copy link
Author

lmbd commented Nov 27, 2022

I would suggest to support decimals as there are gasmeters which are sending an impulse for each 0,01 m^3
Screenshot 2022-11-27 at 21 11 21

Screenshot 2022-11-27 at 21 17 23

@MichaelDvP
Copy link
Contributor

Decimals are supported, value is float, only the browsers handles the input different and give warning if input does not match the step setting. We can remove the up/down arrows and step setting to solve this.

@MichaelDvP
Copy link
Contributor

Ok, removing input props seems to work, please try https://github.com/MichaelDvP/EMS-ESP32/releases

@proddy
Copy link
Contributor

proddy commented Dec 6, 2022

closing. please re-open if this is still an issue

@proddy proddy closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants