[WasmFS] Return errors from getEntries and getNumEntries
#17807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To catch mistakes in backend implementations, assert where possible that error codes are negative.
Make the return type of `getEntries` a variant that can be either a vector of entries as before or a negative error code. Update the return type of `getNumEntries` to be a ssize_t so it can return negative error codes as well. This caps the number of directory entries that can be reported at around two billion, but that should be sufficient. I have manually tested via an injected error that the error handling works correctly for the OPFS backend, although I was not able to construct a test case for this.
This was referenced Sep 6, 2022
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
7 tasks
kripken
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the return type of
getEntriesa variant that can be either a vector ofentries as before or a negative error code. Update the return type of
getNumEntriesto be a ssize_t so it can return negative error codes as well.This caps the number of directory entries that can be reported at around two
billion, but that should be sufficient.
I have manually tested via an injected error that the error handling works
correctly for the OPFS backend, although I was not able to construct a test case
for this.