[WasmFS] Allow backends to report errors from flush
#17781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 1, 2022
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
7 tasks
kripken
approved these changes
Sep 1, 2022
| await accessHandle.flush(); | ||
| } catch { | ||
| let err = -{{{ cDefine('EIO') }}}; | ||
| {{{ makeSetValue('errPtr', 0, 'err', 'i32') }}}; |
There was a problem hiding this comment.
I guess this adds errPtr since there wasn't an existing return value to reuse? Just want to make sure I understand the convention.
There was a problem hiding this comment.
Yeah, exactly. That's what was happening before with setSize as well.
|
Oh right, I forgot that I had been adding |
tlively
force-pushed
the
wasmfs-opfs-errors-refactor
branch
from
410395b to
f449ced
Compare
tlively
force-pushed
the
wasmfs-flush-errors
branch
from
d8dd6fc to
5dffb10
Compare
kripken
approved these changes
Sep 1, 2022
|
Oops, yeah, I meant to put that in the next PR. |
And catch and report such errors in the OPFS backend to prevent errors from causing the async task to hang and create deadlocks.
tlively
force-pushed
the
wasmfs-flush-errors
branch
from
5dffb10 to
af3d713
Compare
This was referenced Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And catch and report such errors in the OPFS backend to prevent errors from
causing the async task to hang and create deadlocks.