[Bugfix Beta] Fix attrs in className and attribute bindings #14384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadhietala
force-pushed
the
attrs-actions
branch
from
5a2174c to
e299630
Compare
chadhietala
force-pushed
the
attrs-actions
branch
from
e299630 to
8502f08
Compare
|
Fixes #14381 |
krisselden
reviewed
Sep 29, 2016
|
|
||
| if (parts.length === 1) { | ||
| return referenceForKey(component, parts[0]); | ||
| } |
There was a problem hiding this comment.
what is the else here? is it supposed to fall through or assert?
There was a problem hiding this comment.
We want this to fall through. So given attrs.foo we want to delegate to referenceForKey, however if we shift off the value and we still have a path e.g. parts.length !== 1 (guranteed to never be 0) then we want to still create a path ref.
| @@ -14,6 +14,17 @@ function referenceForKey(component, key) { | |||
| } | |||
|
|
|||
| function referenceForParts(component, parts) { | |||
| let isAttrs = parts[0] === 'attrs'; | |||
There was a problem hiding this comment.
is parts guaranteed to be length 1? is it very important that we never index outside of the array on get.
There was a problem hiding this comment.
Upstream from this the check is done to make sure we have a path reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.