Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Beta Bug] attrs in bindings are always truthy #14381

Closed
chadhietala opened this issue Sep 29, 2016 · 3 comments
Closed

[Beta Bug] attrs in bindings are always truthy #14381

chadhietala opened this issue Sep 29, 2016 · 3 comments

Comments

@chadhietala
Copy link
Contributor

Repro
https://ember-twiddle.com/7ed79a745f34ce66d44f6b23d5465758?openFiles=templates.application.hbs%2Ctemplates.components.my-component.hbs

We are likely not reading value from the MutableCell and thus the attribute bindings are always true.

@chadhietala chadhietala added this to the 2.9.0 milestone Sep 29, 2016
@HeroicEric
Copy link
Member

We are likely not reading value from the MutableCell and thus the attribute bindings are always true.

Yep. It looks like https://github.com/emberjs/ember.js/blob/master/packages/ember-glimmer/lib/utils/bindings.js#L175, inner is a NestedPropertyReference and inner.value() is a MutableCell, like you said.

@chadhietala
Copy link
Contributor Author

See #14384

@HeroicEric
Copy link
Member

I believe this was fixed by ^^ #14384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants