Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored async helpers to be more robust and fixed some issues with the previous implementation. Before now you couldn't block an async helper by returning any promise.
This didn't work (but now does):
The only two ways that worked were returning
wait
or usingEmber.Test.promise
which shouldn't be public api.Some async helpers were also accidentally triggered synchronously if they were the first helper in a test. People should not rely on this behavior, so now all async helpers are triggered asynchronously. (The checkbox helpers were relying on this unwanted behavior so I fixed them).