Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REGRESSION]: Ember 1.11.0-beta.5 test hangs when element does not exist and trying to use the fillIn helper #10676

Closed
williamsbdev opened this issue Mar 19, 2015 · 4 comments

Comments

@williamsbdev
Copy link

@jcttrll and I noticed that we are using the beta version of Ember 1.11.0-beta.5 and we have a test that is attempting to fillIn an element that does not exist on the page, the test hangs and will not run any other tests. In previous versions, the fillIn helper would alert you and let you know that the element does not exist and fail the test. This is only an issue when you have the andThen in the test. If there is no andThen, it will alert you that the element does not exist and fail the test.

test('do something', function(assert) {
    visit('/');
    fillIn('input.element-does-not-exist-on-page', 'wat');
    andThen(function() {
        assert.equal(1, 1);
    });
});

Thanks for all your work on this awesome project!

@camthompson
Copy link

I've experience this issue as well, but it seems to be fixed in canary already.

@rwjblue rwjblue added this to the 1.11.0 milestone Mar 20, 2015
@rwjblue
Copy link
Member

rwjblue commented Mar 22, 2015

Confirmed. Looking into this now...

Beta (fails): http://emberjs.jsbin.com/rwjblue/344/edit
Canary (doesn't stall): http://emberjs.jsbin.com/rwjblue/346/edit

@rwjblue
Copy link
Member

rwjblue commented Mar 22, 2015

#10463 fixes the hanging test (which is why it is fixed on master). I'm pulling that commit into beta, and marking this as closed.

@rwjblue rwjblue closed this as completed Mar 22, 2015
@williamsbdev
Copy link
Author

@rwjblue Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants