Revert assertion on content attribute and add test to prevent regression #7683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elwayman02
approved these changes
Aug 29, 2021
Revert "[BUGFIX Model] assert when 'content' is used as a property on a record (emberjs#7545)" This reverts commit 1d1496d.
igorT
force-pushed
the
fix-content-revert
branch
from
cb0768c to
10023f6
Compare
igorT
added
🎯 beta
jrjohnson
removed
🎯 beta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened #7682 to be able to illustrate the issue in #7679 with a failing test. This PR adds the same test but also reverts #7545 which is causing the issue 👍 so hopefully the tests will pass.
As with my other PR I know that I'm probably not targeting the right branch here so let me know if you want to merge this and I can retarget the correct branch once it is created 👍