Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX Model] assert when 'content' is used as a property on a record #7545

Merged
merged 1 commit into from
May 25, 2021

Conversation

zinyando
Copy link
Contributor

Resolves #5732 and supersedes #5755

@runspired runspired merged commit 1d1496d into emberjs:master May 25, 2021
@runspired runspired added the 🏷️ bug This PR primarily fixes a reported issue label May 26, 2021
mansona added a commit to mansona/data that referenced this pull request Aug 28, 2021
igorT pushed a commit that referenced this pull request Aug 30, 2021
Revert "[BUGFIX Model] assert when 'content' is used as a property on a record (#7545)"

This reverts commit 1d1496d.
@igorT
Copy link
Member

igorT commented Aug 30, 2021

We had to revert this, as it is a breaking change for people who already have a content attribute.

igorT pushed a commit that referenced this pull request Aug 30, 2021
Revert "[BUGFIX Model] assert when 'content' is used as a property on a record (#7545)"

This reverts commit 1d1496d.
igorT pushed a commit that referenced this pull request Aug 31, 2021
Revert "[BUGFIX Model] assert when 'content' is used as a property on a record (#7545)"

This reverts commit 1d1496d.
igorT pushed a commit that referenced this pull request Aug 31, 2021
Revert "[BUGFIX Model] assert when 'content' is used as a property on a record (#7545)"

This reverts commit 1d1496d.
igorT pushed a commit that referenced this pull request Aug 31, 2021
Revert "[BUGFIX Model] assert when 'content' is used as a property on a record (#7545)"

This reverts commit 1d1496d.
igorT added a commit that referenced this pull request Sep 2, 2021
Revert "[BUGFIX Model] assert when 'content' is used as a property on a record (#7545)"

This reverts commit 1d1496d.

Co-authored-by: Chris Manson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"content" field doesn't work through async relationships
3 participants