[BUGFIX beta] Make Model#data a plain getter.
#4545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Ember 2.9, using an `Ember.computed.alias` or `Ember.computed.readOnly` automatically adds mandatory setter's getter/setter to the properties being watched, and defers reading the current value to the objects own meta. This avoids creating an watcher for `_internalModel` and therefore prevents an error that ocurrs when we attempt to read from `meta` after the object has been destroyed.
bmac
approved these changes
Sep 22, 2016
|
Thanks @rwjblue! |
chancancode
added a commit
to chancancode/emberobserver
that referenced
this pull request
Sep 28, 2016
There is a performance regression with the latest Ember beta that was addressed in Ember Data 2.8.1 (emberjs/data#4545).
wycats
pushed a commit
to tildeio/ember-cli-addon-search
that referenced
this pull request
Oct 12, 2016
There is a performance regression with the latest Ember beta that was addressed in Ember Data 2.8.1 (emberjs/data#4545).
wycats
pushed a commit
to tildeio/ember-cli-addon-search
that referenced
this pull request
Oct 12, 2016
There is a performance regression with the latest Ember beta that was addressed in Ember Data 2.8.1 (emberjs/data#4545).
wycats
pushed a commit
to tildeio/ember-cli-addon-search
that referenced
this pull request
Oct 12, 2016
There is a performance regression with the latest Ember beta that was addressed in Ember Data 2.8.1 (emberjs/data#4545).
wycats
pushed a commit
to tildeio/ember-cli-addon-search
that referenced
this pull request
Oct 12, 2016
There is a performance regression with the latest Ember beta that was addressed in Ember Data 2.8.1 (emberjs/data#4545).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ember 2.9, using an
Ember.computed.aliasorEmber.computed.readOnlyautomatically adds mandatory setter's getter/setter to the properties being watched, and defers reading the current value to the objects own meta.This avoids creating an watcher for
_internalModeland therefore prevents an error that ocurrs when we attempt to read frommetaafter the object has been destroyed.